Commit9f1cf97

committed

Print WAL logical message contents in pg_waldump

This helps debuggability when looking at WAL streams containing logicalmessages.Author: Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>Reviewed-by: Álvaro Herrera <alvherre@alvh.no-ip.org>Discussion:https://postgr.es/m/CAExHW5sWx49rKmXbg5H1Xc1t+nRv9PaYKQmgw82HPt6vWDVmDg@mail.gmail.com

1 parent58c6fec commit9f1cf97Copy full SHA for 9f1cf97

File tree

+17

-6

lines changed

+17

-6

lines changed

Lines changed: 14 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,10 +24,21 @@ logicalmsg_desc(StringInfo buf, XLogReaderState *record)`
`24`	`24`	`if (info==XLOG_LOGICAL_MESSAGE)`
`25`	`25`	`{`
`26`	`26`	`xl_logical_messagexlrec= (xl_logical_message)rec;`
	`27`	`+char*prefix=xlrec->message;`
	`28`	`+char*message=xlrec->message+xlrec->prefix_size;`
	`29`	`+char*sep="";`
`27`	`30`
`28`		`-appendStringInfo(buf,"%s message size %zu bytes",`
`29`		`-xlrec->transactional ?"transactional" :"nontransactional",`
`30`		`-xlrec->message_size);`
	`31`	`+Assert(prefix[xlrec->prefix_size]!='\0');`
	`32`	`+`
	`33`	`+appendStringInfo(buf,"%s, prefix \"%s\"; payload (%zu bytes): ",`
	`34`	`+xlrec->transactional ?"transactional" :"non-transactional",`
	`35`	`+prefix,xlrec->message_size);`
	`36`	`+/* Write message payload as a series of hex bytes */`
	`37`	`+for (intcnt=0;cnt<xlrec->message_size;cnt++)`
	`38`	`+{`
	`39`	`+appendStringInfo(buf,"%s%02X",sep, (unsignedchar)message[cnt]);`
	`40`	`+sep=" ";`
	`41`	`+}`
`31`	`42`	`}`
`32`	`43`	`}`
`33`	`44`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,7 @@ LogLogicalMessage(const char prefix, const char message, size_t size,`
`59`	`59`
`60`	`60`	`xlrec.dbId=MyDatabaseId;`
`61`	`61`	`xlrec.transactional=transactional;`
	`62`	`+/* trailing zero is critical; see logicalmsg_desc */`
`62`	`63`	`xlrec.prefix_size=strlen(prefix)+1;`
`63`	`64`	`xlrec.message_size=size;`
`64`	`65`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,9 +23,8 @@ typedef struct xl_logical_message`
`23`	`23`	`booltransactional;/* is message transactional? */`
`24`	`24`	`Sizeprefix_size;/* length of prefix */`
`25`	`25`	`Sizemessage_size;/* size of the message */`
`26`		`-charmessage[FLEXIBLE_ARRAY_MEMBER];/* message including the null`
`27`		`- * terminated prefix of length`
`28`		`- * prefix_size */`
	`26`	`+/* payload, including null-terminated prefix of length prefix_size */`
	`27`	`+charmessage[FLEXIBLE_ARRAY_MEMBER];`
`29`	`28`	`}xl_logical_message;`
`30`	`29`
`31`	`30`	`#defineSizeOfLogicalMessage(offsetof(xl_logical_message, message))`

Comments

(0)