forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit9f12da7
committed
Lock table in ShareUpdateExclusive when importing index stats.
Follow locking behavior of ANALYZE when importing statistics. Inparticular, when importing index statistics, the table must be lockedin ShareUpdateExclusive mode. Fixes bug reportd by Jian He.ANALYZE doesn't update statistics on partitioned indexes, and thelocking requirements are slightly different for in-place updates onpartitioned indexes versus normal indexes. To be conservative, lockboth the partitioned table and the partitioned index inShareUpdateExclusive mode when importing stats for a partitionedindex.Author: Corey HuinkerReported-by: Jian HeReviewed-by: Michael PaquierDiscussion:https://www.postgresql.org/message-id/CACJufxGreTY7qsCV8%2BBkuv0p5SXGTScgh%3DD%2BDq6%3D%2B_%3DXTp7FWg%40mail.gmail.com1 parent979205e commit9f12da7
File tree
3 files changed
+228
-13
lines changed- src
- backend/statistics
- test/regress
- expected
- sql
3 files changed
+228
-13
lines changedLines changed: 57 additions & 13 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
17 | 17 |
| |
18 | 18 |
| |
19 | 19 |
| |
| 20 | + | |
20 | 21 |
| |
21 | 22 |
| |
22 | 23 |
| |
23 | 24 |
| |
| 25 | + | |
24 | 26 |
| |
25 | 27 |
| |
26 | 28 |
| |
| 29 | + | |
27 | 30 |
| |
28 | 31 |
| |
29 | 32 |
| |
| |||
126 | 129 |
| |
127 | 130 |
| |
128 | 131 |
| |
129 |
| - | |
130 |
| - | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
131 | 136 |
| |
132 |
| - | |
133 |
| - | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
134 | 147 |
| |
135 |
| - | |
136 | 148 |
| |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
137 | 168 |
| |
138 | 169 |
| |
139 | 170 |
| |
140 |
| - | |
141 | 171 |
| |
142 | 172 |
| |
143 | 173 |
| |
144 | 174 |
| |
145 | 175 |
| |
146 |
| - | |
147 |
| - | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
148 | 191 |
| |
149 | 192 |
| |
150 |
| - | |
| 193 | + | |
151 | 194 |
| |
152 | 195 |
| |
153 | 196 |
| |
154 | 197 |
| |
155 | 198 |
| |
156 | 199 |
| |
157 |
| - | |
| 200 | + | |
158 | 201 |
| |
159 | 202 |
| |
160 | 203 |
| |
161 | 204 |
| |
162 | 205 |
| |
163 |
| - | |
164 |
| - | |
| 206 | + | |
| 207 | + | |
165 | 208 |
| |
166 | 209 |
| |
167 |
| - | |
| 210 | + | |
| 211 | + | |
168 | 212 |
| |
169 | 213 |
| |
170 | 214 |
| |
|
Lines changed: 103 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
85 | 85 |
| |
86 | 86 |
| |
87 | 87 |
| |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
88 | 126 |
| |
89 | 127 |
| |
90 | 128 |
| |
| |||
182 | 220 |
| |
183 | 221 |
| |
184 | 222 |
| |
| 223 | + | |
185 | 224 |
| |
186 | 225 |
| |
187 | 226 |
| |
| |||
193 | 232 |
| |
194 | 233 |
| |
195 | 234 |
| |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
196 | 244 |
| |
197 | 245 |
| |
198 | 246 |
| |
| |||
202 | 250 |
| |
203 | 251 |
| |
204 | 252 |
| |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
205 | 295 |
| |
206 | 296 |
| |
207 | 297 |
| |
| |||
1414 | 1504 |
| |
1415 | 1505 |
| |
1416 | 1506 |
| |
| 1507 | + | |
| 1508 | + | |
| 1509 | + | |
| 1510 | + | |
| 1511 | + | |
| 1512 | + | |
| 1513 | + | |
| 1514 | + | |
| 1515 | + | |
| 1516 | + | |
| 1517 | + | |
| 1518 | + | |
| 1519 | + | |
1417 | 1520 |
| |
1418 | 1521 |
| |
1419 | 1522 |
| |
|
Lines changed: 68 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
64 | 64 |
| |
65 | 65 |
| |
66 | 66 |
| |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
67 | 91 |
| |
68 | 92 |
| |
69 | 93 |
| |
| |||
127 | 151 |
| |
128 | 152 |
| |
129 | 153 |
| |
| 154 | + | |
| 155 | + | |
130 | 156 |
| |
131 | 157 |
| |
132 | 158 |
| |
| |||
135 | 161 |
| |
136 | 162 |
| |
137 | 163 |
| |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
138 | 169 |
| |
139 | 170 |
| |
140 | 171 |
| |
141 | 172 |
| |
142 | 173 |
| |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
143 | 202 |
| |
144 | 203 |
| |
145 | 204 |
| |
| |||
1062 | 1121 |
| |
1063 | 1122 |
| |
1064 | 1123 |
| |
| 1124 | + | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
1065 | 1133 |
| |
1066 | 1134 |
| |
1067 | 1135 |
| |
|
0 commit comments
Comments
(0)