Commit9effa55

Amit Kapila

committed

Deduplicate handling of binary and text modes in logicalrep_read_tuple().

1 parentce340e5 commit9effa55Copy full SHA for 9effa55

File tree

-12

lines changed

-12

lines changed

Lines changed: 6 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -895,25 +895,19 @@ logicalrep_read_tuple(StringInfo in, LogicalRepTupleData *tuple)`
`895`	`895`	`/* we don't receive the value of an unchanged column */`
`896`	`896`	`break;`
`897`	`897`	`caseLOGICALREP_COLUMN_TEXT:`
`898`		`-len=pq_getmsgint(in,4);/* read length */`
`899`		`-`
`900`		`-/* and data */`
`901`		`-value->data=palloc(len+1);`
`902`		`-pq_copymsgbytes(in,value->data,len);`
`903`		`-value->data[len]='\0';`
`904`		`-/* make StringInfo fully valid */`
`905`		`-value->len=len;`
`906`		`-value->cursor=0;`
`907`		`-value->maxlen=len;`
`908`		`-break;`
`909`	`898`	`caseLOGICALREP_COLUMN_BINARY:`
`910`	`899`	`len=pq_getmsgint(in,4);/* read length */`
`911`	`900`
`912`	`901`	`/* and data */`
`913`	`902`	`value->data=palloc(len+1);`
`914`	`903`	`pq_copymsgbytes(in,value->data,len);`
`915`		`-/* not strictly necessary but per StringInfo practice */`
	`904`	`+`
	`905`	`+/*`
	`906`	`+ * Not strictly necessary for LOGICALREP_COLUMN_BINARY, but`
	`907`	`+ * per StringInfo practice.`
	`908`	`+ */`
`916`	`909`	`value->data[len]='\0';`
	`910`	`+`
`917`	`911`	`/* make StringInfo fully valid */`
`918`	`912`	`value->len=len;`
`919`	`913`	`value->cursor=0;`

Comments

(0)