Commit9ef993d

petergeoghegan

authored and

pull[bot]

committed

Fix comments about deduplication updating page.

nbtree deduplication passes add tuples from the original/target page toa temp page, merging as necessary. The temp page is copied back to thetarget permanent page in the critical section. This is similar to theapproach taken by nbtree page splits.Adjust comments that referred to updating the original page in-place astuples were merged. These were left over from earlier versions of thededuplication patch that didn't yet use a temp page.

1 parent461e069 commit9ef993dCopy full SHA for 9ef993d

File tree

1 file changed

-3

lines changed

src/backend/access/nbtree
- nbtdedup.c

1 file changed

-3

lines changed

`‎src/backend/access/nbtree/nbtdedup.c`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -166,8 +166,8 @@ _bt_dedup_pass(Relation rel, Buffer buf, Relation heapRel, IndexTuple newitem,`
`166`	`166`	`* maxpostingsize).`
`167`	`167`	`*`
`168`	`168`	`* If state contains pending posting list with more than one item,`
`169`		`- * form new posting tuple, andactually update the page. Else`
`170`		`- *reset the state and move on without modifyingthe page.`
	`169`	`+ * form new posting tuple andadd it to our temp page (newpage).`
	`170`	`+ *Else add pending interval's base tuple tothetemppage as-is.`
`171`	`171`	`*/`
`172`	`172`	`pagesaving+=_bt_dedup_finish_pending(newpage,state);`
`173`	`173`
`@@ -184,7 +184,8 @@ _bt_dedup_pass(Relation rel, Buffer buf, Relation heapRel, IndexTuple newitem,`
`184`	`184`	`* stop merging together tuples altogether. The few tuples`
`185`	`185`	`* that remain at the end of the page won't be merged together`
`186`	`186`	`* at all (at least not until after a future page split takes`
`187`		`- * place).`
	`187`	`+ * place, when this page's newly allocated right sibling page`
	`188`	`+ * gets its first deduplication pass).`
`188`	`189`	`*/`
`189`	`190`	`if (state->nmaxitems==5)`
`190`	`191`	`_bt_singleval_fillfactor(page,state,newitemsz);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9ef993d

File tree

1 file changed

1 file changed

`‎src/backend/access/nbtree/nbtdedup.c`

0 commit comments