NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9ef5a35

committed

Fix custom validators call in build_local_reloptions()

We need to call them only when validate == true.Backpatch to 13, where opclass options were introduced.Reported-by: Tom LaneDiscussion:https://postgr.es/m/2656633.1681831542%40sss.pgh.pa.usReviewed-by: Tom Lane, Pavel BorisovBackpatch-through: 13

1 parentdde926b commit9ef5a35Copy full SHA for 9ef5a35

File tree

1 file changed

-2

lines changed

src/backend/access/common
- reloptions.c

1 file changed

-2

lines changed

`‎src/backend/access/common/reloptions.c`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1963,8 +1963,9 @@ build_local_reloptions(local_relopts *relopts, Datum options, bool validate)`
`1963`	`1963`	`fillRelOptions(opts,relopts->relopt_struct_size,vals,noptions,validate,`
`1964`	`1964`	`elems,noptions);`
`1965`	`1965`
`1966`		`-foreach(lc,relopts->validators)`
`1967`		`-((relopts_validator)lfirst(lc)) (opts,vals,noptions);`
	`1966`	`+if (validate)`
	`1967`	`+foreach(lc,relopts->validators)`
	`1968`	`+((relopts_validator)lfirst(lc)) (opts,vals,noptions);`
`1968`	`1969`
`1969`	`1970`	`if (elems)`
`1970`	`1971`	`pfree(elems);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9ef5a35

File tree

1 file changed

1 file changed

`‎src/backend/access/common/reloptions.c`

0 commit comments