NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9ebfbd2

committed

Fix NaN comparison in circle_same test

Commitc4c3400 changed geometric operators to use float4 and float8functions, and handle NaN's in a better way. The circle sameness testhad a typo in the code which resulted in all comparisons with the leftcircle having a NaN radius considered same. postgres=# select '<(0,0),NaN>'::circle ~= '<(0,0),1>'::circle; ?column? ---------- t (1 row)This fixes the sameness test to consider the radius of both the leftand right circle.Backpatch to v12 where this was introduced.Author: Ranier Vilela <ranier.vf@gmail.com>Discussion:https://postgr.es/m/CAEudQAo8dK=yctg2ZzjJuzV4zgOPBxRU5+Kb+yatFiddtQk6Rw@mail.gmail.comBackpatch-through: v12

1 parent9fbc6d5 commit9ebfbd2Copy full SHA for 9ebfbd2

File tree

2 files changed

-3

lines changed

src
- backend/utils/adt
  - geo_ops.c
- test/regress/expected
  - geometry.out

2 files changed

-3

lines changed

`‎src/backend/utils/adt/geo_ops.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4635,7 +4635,7 @@ circle_same(PG_FUNCTION_ARGS)`
`4635`	`4635`	`CIRCLE*circle1=PG_GETARG_CIRCLE_P(0);`
`4636`	`4636`	`CIRCLE*circle2=PG_GETARG_CIRCLE_P(1);`
`4637`	`4637`
`4638`		`-PG_RETURN_BOOL(((isnan(circle1->radius)&&isnan(circle1->radius))\|\|`
	`4638`	`+PG_RETURN_BOOL(((isnan(circle1->radius)&&isnan(circle2->radius))\|\|`
`4639`	`4639`	`FPeq(circle1->radius,circle2->radius))&&`
`4640`	`4640`	`point_eq_point(&circle1->center,&circle2->center));`
`4641`	`4641`	`}`

`‎src/test/regress/expected/geometry.out`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -4056,9 +4056,8 @@ SELECT c1.f1, c2.f1 FROM CIRCLE_TBL c1, CIRCLE_TBL c2 WHERE c1.f1 ~= c2.f1;`
`4056`	`4056`	`<(100,200),10> \| <(100,200),10>`
`4057`	`4057`	`<(100,1),115> \| <(100,1),115>`
`4058`	`4058`	`<(3,5),0> \| <(3,5),0>`
`4059`		`- <(3,5),NaN> \| <(3,5),0>`
`4060`	`4059`	`<(3,5),NaN> \| <(3,5),NaN>`
`4061`		`-(9 rows)`
	`4060`	`+(8 rows)`
`4062`	`4061`
`4063`	`4062`	`-- Overlap with circle`
`4064`	`4063`	`SELECT c1.f1, c2.f1 FROM CIRCLE_TBL c1, CIRCLE_TBL c2 WHERE c1.f1 && c2.f1;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9ebfbd2

File tree

2 files changed

2 files changed

`‎src/backend/utils/adt/geo_ops.c`

`‎src/test/regress/expected/geometry.out`

0 commit comments