NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9e49676

committed

Remove unnecessary "DISTINCT" in psql's queries for \dAc and \dAf.

A moment's examination of these queries is sufficient to see thatthey do not produce duplicate rows, unless perhaps there'scatalog corruption. Using DISTINCT anyway is inefficient andconfusing; moreover it sets a poor example for anyone whorefers to psql -E output to see how to query the catalogs.

1 parenteeb01e3 commit9e49676Copy full SHA for 9e49676

File tree

1 file changed

-2

lines changed

src/bin/psql
- describe.c

1 file changed

-2

lines changed

`‎src/bin/psql/describe.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -6071,7 +6071,7 @@ listOperatorClasses(const char *access_method_pattern,`
`6071`	`6071`	`initPQExpBuffer(&buf);`
`6072`	`6072`
`6073`	`6073`	`printfPQExpBuffer(&buf,`
`6074`		`-"SELECT DISTINCT"`
	`6074`	`+"SELECT\n"`
`6075`	`6075`	`" am.amname AS \"%s\",\n"`
`6076`	`6076`	`" pg_catalog.format_type(c.opcintype, NULL) AS \"%s\",\n"`
`6077`	`6077`	`" CASE\n"`
`@@ -6166,7 +6166,7 @@ listOperatorFamilies(const char *access_method_pattern,`
`6166`	`6166`	`initPQExpBuffer(&buf);`
`6167`	`6167`
`6168`	`6168`	`printfPQExpBuffer(&buf,`
`6169`		`-"SELECT DISTINCT"`
	`6169`	`+"SELECT\n"`
`6170`	`6170`	`" am.amname AS \"%s\",\n"`
`6171`	`6171`	`" CASE\n"`
`6172`	`6172`	`" WHEN pg_catalog.pg_opfamily_is_visible(f.oid)\n"`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9e49676

File tree

1 file changed

1 file changed

`‎src/bin/psql/describe.c`

0 commit comments