NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9e20406

committed

Fix unportable use of isprint().

We must cast the arguments of <ctype.h> functions to unsignedchar to avoid problems where char is signed.Speaking of which, considering that this *is* a <ctype.h> function,it's rather remarkable that we aren't seeing more complaints aboutnot having included that header.Per buildfarm.

1 parentf1be740 commit9e20406Copy full SHA for 9e20406

File tree

1 file changed

-2

lines changed

src/interfaces/libpq
- fe-trace.c

1 file changed

-2

lines changed

`‎src/interfaces/libpq/fe-trace.c`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@`
`14`	`14`
`15`	`15`	`#include"postgres_fe.h"`
`16`	`16`
	`17`	`+#include<ctype.h>`
`17`	`18`	`#include<limits.h>`
`18`	`19`	`#include<time.h>`
`19`	`20`
`@@ -28,6 +29,7 @@`
`28`	`29`	`#include"libpq-int.h"`
`29`	`30`	`#include"port/pg_bswap.h"`
`30`	`31`
	`32`	`+`
`31`	`33`	`/* Enable tracing */`
`32`	`34`	`void`
`33`	`35`	`PQtrace(PGconnconn,FILEdebug_port)`
`@@ -102,7 +104,7 @@ pqTraceOutputByte1(FILE pfdebug, const char data, int *cursor)`
`102`	`104`	`* Show non-printable data in hex format, including the terminating \0`
`103`	`105`	`* that completes ErrorResponse and NoticeResponse messages.`
`104`	`106`	`*/`
`105`		`-if (!isprint(*v))`
	`107`	`+if (!isprint((unsignedchar)*v))`
`106`	`108`	`fprintf(pfdebug," \\x%02x",*v);`
`107`	`109`	`else`
`108`	`110`	`fprintf(pfdebug," %c",*v);`
`@@ -186,7 +188,7 @@ pqTraceOutputNchar(FILE pfdebug, int len, const char data, int *cursor)`
`186`	`188`
`187`	`189`	`for (next=i=0;i<len;++i)`
`188`	`190`	`{`
`189`		`-if (isprint(v[i]))`
	`191`	`+if (isprint((unsignedchar)v[i]))`
`190`	`192`	`continue;`
`191`	`193`	`else`
`192`	`194`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9e20406

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/fe-trace.c`

0 commit comments