NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9df8727

committed

Add tab completion for ALTER DATABASE RESET

Currently tab completion for ALTER DATABASE RESET shows a list of allconfiguration parameters that may be set on a database, irrespectivelyof which parameters are actually set. This patch improves tab completionto offer only parameters that are set.Author: Robins TharakanReviewed-By: Tomas VondraDiscussion:https://postgr.es/m/CAEP4nAzqiT6VbVC5r3nq5byLTnPzjniVGzEMpYcnAHQyNzEuaw%40mail.gmail.com

1 parentfc069a3 commit9df8727Copy full SHA for 9df8727

File tree

1 file changed

+19

-1

lines changed

src/bin/psql
- tab-complete.in.c

1 file changed

+19

-1

lines changed

`‎src/bin/psql/tab-complete.in.c`

Lines changed: 19 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1000,6 +1000,15 @@ static const SchemaQuery Query_for_trigger_of_table = {`
`1000`	`1000`	`"SELECT datname FROM pg_catalog.pg_database "\`
`1001`	`1001`	`" WHERE datname LIKE '%s'"`
`1002`	`1002`
	`1003`	`+#defineQuery_for_list_of_database_vars \`
	`1004`	`+"SELECT conf FROM ("\`
	`1005`	`+" SELECT setdatabase, pg_catalog.split_part(unnest(setconfig),'=',1) conf"\`
	`1006`	`+" FROM pg_db_role_setting "\`
	`1007`	`+" ) s, pg_database d "\`
	`1008`	`+" WHERE s.setdatabase = d.oid "\`
	`1009`	`+" AND conf LIKE '%s'"\`
	`1010`	`+" AND d.datname LIKE '%s'"`
	`1011`	`+`
`1003`	`1012`	`#defineQuery_for_list_of_tablespaces \`
`1004`	`1013`	`"SELECT spcname FROM pg_catalog.pg_tablespace "\`
`1005`	`1014`	`" WHERE spcname LIKE '%s'"`
`@@ -2320,6 +2329,13 @@ match_previous_words(int pattern_id,`
`2320`	`2329`	`"IS_TEMPLATE","ALLOW_CONNECTIONS",`
`2321`	`2330`	`"CONNECTION LIMIT");`
`2322`	`2331`
	`2332`	`+/* ALTER DATABASE <name> RESET */`
	`2333`	`+elseif (Matches("ALTER","DATABASE",MatchAny,"RESET"))`
	`2334`	`+{`
	`2335`	`+set_completion_reference(prev2_wd);`
	`2336`	`+COMPLETE_WITH_QUERY_PLUS(Query_for_list_of_database_vars,"ALL");`
	`2337`	`+}`
	`2338`	`+`
`2323`	`2339`	`/* ALTER DATABASE <name> SET TABLESPACE */`
`2324`	`2340`	`elseif (Matches("ALTER","DATABASE",MatchAny,"SET","TABLESPACE"))`
`2325`	`2341`	`COMPLETE_WITH_QUERY(Query_for_list_of_tablespaces);`
`@@ -4906,7 +4922,9 @@ match_previous_words(int pattern_id,`
`4906`	`4922`
`4907`	`4923`	`/* SET, RESET, SHOW */`
`4908`	`4924`	`/* Complete with a variable name */`
`4909`		`-elseif (TailMatches("SET\|RESET")&& !TailMatches("UPDATE",MatchAny,"SET"))`
	`4925`	`+elseif (TailMatches("SET\|RESET")&&`
	`4926`	`+ !TailMatches("UPDATE",MatchAny,"SET")&&`
	`4927`	`+ !TailMatches("ALTER","DATABASE",MatchAny,"RESET"))`
`4910`	`4928`	`COMPLETE_WITH_QUERY_VERBATIM_PLUS(Query_for_list_of_set_vars,`
`4911`	`4929`	`"CONSTRAINTS",`
`4912`	`4930`	`"TRANSACTION",`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9df8727

File tree

1 file changed

1 file changed

`‎src/bin/psql/tab-complete.in.c`

0 commit comments