NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9df2a4b

committed

Add missing BUFFERS OFF in regression tests, take 2

Similar to9fa1aaa, but running with -D RELCACHE_FORCE_RELEASE and-D CATCACHE_FORCE_RELEASE yielded some additional missing places thatneeded BUFFERS OFF.Discussion:https://postgr.es/m/CANNMO++W7MM8T0KyXN3ZheXXt-uLVM3aEtZd+WNfZ=obxffUiA@mail.gmail.com

1 parent9fa1aaa commit9df2a4bCopy full SHA for 9df2a4b

File tree

4 files changed

+14

-14

lines changed

src/test/regress
- expected
  - matview.out
  - misc_functions.out
- sql
  - matview.sql
  - misc_functions.sql

4 files changed

+14

-14

lines changed

`‎src/test/regress/expected/matview.out`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -624,7 +624,7 @@ GRANT ALL ON SCHEMA matview_schema TO public;`
`624`	`624`	`SET SESSION AUTHORIZATION regress_matview_user;`
`625`	`625`	`CREATE MATERIALIZED VIEW matview_schema.mv_withdata1 (a) AS`
`626`	`626`	`SELECT generate_series(1, 10) WITH DATA;`
`627`		`-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)`
	`627`	`+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)`
`628`	`628`	`CREATE MATERIALIZED VIEW matview_schema.mv_withdata2 (a) AS`
`629`	`629`	`SELECT generate_series(1, 10) WITH DATA;`
`630`	`630`	`QUERY PLAN`
`@@ -636,7 +636,7 @@ EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)`
`636`	`636`	`REFRESH MATERIALIZED VIEW matview_schema.mv_withdata2;`
`637`	`637`	`CREATE MATERIALIZED VIEW matview_schema.mv_nodata1 (a) AS`
`638`	`638`	`SELECT generate_series(1, 10) WITH NO DATA;`
`639`		`-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)`
	`639`	`+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)`
`640`	`640`	`CREATE MATERIALIZED VIEW matview_schema.mv_nodata2 (a) AS`
`641`	`641`	`SELECT generate_series(1, 10) WITH NO DATA;`
`642`	`642`	`QUERY PLAN`
`@@ -669,23 +669,23 @@ ERROR: relation "matview_ine_tab" already exists`
`669`	`669`	`CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS`
`670`	`670`	`SELECT 1 / 0 WITH NO DATA; -- ok`
`671`	`671`	`NOTICE: relation "matview_ine_tab" already exists, skipping`
`672`		`-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)`
	`672`	`+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)`
`673`	`673`	`CREATE MATERIALIZED VIEW matview_ine_tab AS`
`674`	`674`	`SELECT 1 / 0; -- error`
`675`	`675`	`ERROR: relation "matview_ine_tab" already exists`
`676`		`-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)`
	`676`	`+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)`
`677`	`677`	`CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS`
`678`	`678`	`SELECT 1 / 0; -- ok`
`679`	`679`	`NOTICE: relation "matview_ine_tab" already exists, skipping`
`680`	`680`	`QUERY PLAN`
`681`	`681`	`------------`
`682`	`682`	`(0 rows)`
`683`	`683`
`684`		`-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)`
	`684`	`+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)`
`685`	`685`	`CREATE MATERIALIZED VIEW matview_ine_tab AS`
`686`	`686`	`SELECT 1 / 0 WITH NO DATA; -- error`
`687`	`687`	`ERROR: relation "matview_ine_tab" already exists`
`688`		`-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)`
	`688`	`+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)`
`689`	`689`	`CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS`
`690`	`690`	`SELECT 1 / 0 WITH NO DATA; -- ok`
`691`	`691`	`NOTICE: relation "matview_ine_tab" already exists, skipping`

`‎src/test/regress/expected/misc_functions.out`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ BEGIN`
`22`	`22`	`SET LOCAL jit = 0;`
`23`	`23`
`24`	`24`	`FOR ln IN`
`25`		`- EXECUTE format('explain (analyze %s, costs on, summary off, timing off) %s',`
	`25`	`+ EXECUTE format('explain (analyze %s, costs on, summary off, timing off, buffers off) %s',`
`26`	`26`	`analyze_str, query)`
`27`	`27`	`LOOP`
`28`	`28`	`IF hide_costs = true THEN`

`‎src/test/regress/sql/matview.sql`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -274,13 +274,13 @@ GRANT ALL ON SCHEMA matview_schema TO public;`
`274`	`274`	`SET SESSION AUTHORIZATION regress_matview_user;`
`275`	`275`	`CREATE MATERIALIZED VIEWmatview_schema.mv_withdata1 (a)AS`
`276`	`276`	`SELECT generate_series(1,10) WITH DATA;`
`277`		`-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)`
	`277`	`+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)`
`278`	`278`	`CREATE MATERIALIZED VIEWmatview_schema.mv_withdata2 (a)AS`
`279`	`279`	`SELECT generate_series(1,10) WITH DATA;`
`280`	`280`	`REFRESH MATERIALIZED VIEWmatview_schema.mv_withdata2;`
`281`	`281`	`CREATE MATERIALIZED VIEWmatview_schema.mv_nodata1 (a)AS`
`282`	`282`	`SELECT generate_series(1,10) WITH NO DATA;`
`283`		`-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)`
	`283`	`+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)`
`284`	`284`	`CREATE MATERIALIZED VIEWmatview_schema.mv_nodata2 (a)AS`
`285`	`285`	`SELECT generate_series(1,10) WITH NO DATA;`
`286`	`286`	`REFRESH MATERIALIZED VIEWmatview_schema.mv_nodata2;`
`@@ -301,16 +301,16 @@ CREATE MATERIALIZED VIEW matview_ine_tab AS`
`301`	`301`	`SELECT1/0 WITH NO DATA;-- error`
`302`	`302`	`CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tabAS`
`303`	`303`	`SELECT1/0 WITH NO DATA;-- ok`
`304`		`-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)`
	`304`	`+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)`
`305`	`305`	`CREATE MATERIALIZED VIEW matview_ine_tabAS`
`306`	`306`	`SELECT1/0;-- error`
`307`		`-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)`
	`307`	`+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)`
`308`	`308`	`CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tabAS`
`309`	`309`	`SELECT1/0;-- ok`
`310`		`-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)`
	`310`	`+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)`
`311`	`311`	`CREATE MATERIALIZED VIEW matview_ine_tabAS`
`312`	`312`	`SELECT1/0 WITH NO DATA;-- error`
`313`		`-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)`
	`313`	`+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)`
`314`	`314`	`CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tabAS`
`315`	`315`	`SELECT1/0 WITH NO DATA;-- ok`
`316`	`316`	`DROP MATERIALIZED VIEW matview_ine_tab;`

`‎src/test/regress/sql/misc_functions.sql`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ BEGIN`
`24`	`24`	`SET LOCAL jit=0;`
`25`	`25`
`26`	`26`	`FOR lnIN`
`27`		`- EXECUTE format('explain (analyze %s, costs on, summary off, timing off) %s',`
	`27`	`+ EXECUTE format('explain (analyze %s, costs on, summary off, timing off, buffers off) %s',`
`28`	`28`	`analyze_str, query)`
`29`	`29`	`LOOP`
`30`	`30`	`IF hide_costs= true THEN`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9df2a4b

File tree

4 files changed

4 files changed

`‎src/test/regress/expected/matview.out`

`‎src/test/regress/expected/misc_functions.out`

`‎src/test/regress/sql/matview.sql`

`‎src/test/regress/sql/misc_functions.sql`

0 commit comments