Commit9ddda58

committed

ecpg: Fix off-by-one error in memory copying

In a rare case, one byte past the end of memory belonging to thesqlca_t structure would be written to.found by Coverity

1 parentb108a77 commit9ddda58Copy full SHA for 9ddda58

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -532,7 +532,7 @@ ECPGset_var(int number, void *pointer, int lineno)`
`532`	`532`	`structsqlca_t*sqlca=ECPGget_sqlca();`
`533`	`533`
`534`	`534`	`sqlca->sqlcode=ECPG_OUT_OF_MEMORY;`
`535`		`-strncpy(sqlca->sqlstate,"YE001",sizeof("YE001"));`
	`535`	`+strncpy(sqlca->sqlstate,"YE001",sizeof(sqlca->sqlstate));`
`536`	`536`	`snprintf(sqlca->sqlerrm.sqlerrmc,sizeof(sqlca->sqlerrm.sqlerrmc),"out of memory on line %d",lineno);`
`537`	`537`	`sqlca->sqlerrm.sqlerrml=strlen(sqlca->sqlerrm.sqlerrmc);`
`538`	`538`	`/* free all memory we have allocated for the user */`

Comments

(0)