NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9dc3c54

committed

pg_dump: tests: Correct test condition for invalid databases

For some reason I used not_like = { pg_dumpall_dbprivs => 1, } in the testcondition of one of the tests added in inc66a7d7. That doesn't make sensefor two reasons: 1) not_like isn't a valid test condition 2) the databaseshould not be dumped in any of the tests. Due to 1), the test achieved itsgoal, but clearly the formulation is confusing. Instead use like => {}, witha comment explaining why.Reported-by: Peter Eisentraut <peter@eisentraut.org>Discussion:https://postgr.es/m/3ddf79f2-8b7b-a093-11d2-5c739bc64f86@eisentraut.orgBackpatch: 11-, likec66a7d7

1 parent0e59266 commit9dc3c54Copy full SHA for 9dc3c54

File tree

1 file changed

-3

lines changed

src/bin/pg_dump/t
- 002_pg_dump.pl

1 file changed

-3

lines changed

`‎src/bin/pg_dump/t/002_pg_dump.pl`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1581,9 +1581,9 @@`
`1581`	`1581`	`CREATE DATABASE regression_invalid;`
`1582`	`1582`	`UPDATE pg_database SET datconnlimit = -2 WHERE datname = 'regression_invalid'),`
`1583`	`1583`	`regexp=>qr/^CREATE DATABASE regression_invalid/m,`
`1584`		`-not_like=> {`
`1585`		`-pg_dumpall_dbprivs=> 1,`
`1586`		`-},`
	`1584`	`+`
	`1585`	`+# invalid databases should never be dumped`
	`1586`	`+like=> {},`
`1587`	`1587`	`},`
`1588`	`1588`
`1589`	`1589`	`'CREATE ACCESS METHOD gist2'=> {`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9dc3c54

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/t/002_pg_dump.pl`

0 commit comments