Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit9dbf2b7

Browse files
committed
Restructure SELECT INTO's parsetree representation into CreateTableAsStmt.
Making this operation look like a utility statement seems generally a goodidea, and particularly so in light of the desire to provide commandtriggers for utility statements. The original choice of representing it asSELECT with an IntoClause appendage had metastasized into rather a lot ofplaces, unfortunately, so that this patch is a great deal more complicatedthan one might at first expect.In particular, keeping EXPLAIN working for SELECT INTO and CREATE TABLE ASsubcommands required restructuring some EXPLAIN-related APIs. Add-on codethat calls ExplainOnePlan or ExplainOneUtility, or usesExplainOneQuery_hook, will need adjustment.Also, the cases PREPARE ... SELECT INTO and CREATE RULE ... SELECT INTO,which formerly were accepted though undocumented, are no longer accepted.The PREPARE case can be replaced with use of CREATE TABLE AS EXECUTE.The CREATE RULE case doesn't seem to have much real-world use (since therule would work only once before failing with "table already exists"),so we'll not bother with that one.Both SELECT INTO and CREATE TABLE AS still return a command tag of"SELECT nnnn". There was some discussion of returning "CREATE TABLE nnnn",but for the moment backwards compatibility wins the day.Andres Freund and Tom Lane
1 parent77503a7 commit9dbf2b7

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+963
-729
lines changed

‎src/backend/commands/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ top_builddir = ../../..
1313
include$(top_builddir)/src/Makefile.global
1414

1515
OBJS = aggregatecmds.o alter.o analyze.o async.o cluster.o comment.o\
16-
collationcmds.o constraint.o conversioncmds.o copy.o\
16+
collationcmds.o constraint.o conversioncmds.o copy.ocreateas.o\
1717
dbcommands.o define.o discard.o dropcmds.o explain.o extension.o\
1818
foreigncmds.o functioncmds.o\
1919
indexcmds.o lockcmds.o operatorcmds.o opclasscmds.o\

‎src/backend/commands/copy.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1210,15 +1210,17 @@ BeginCopy(bool is_from,
12101210
elog(ERROR,"unexpected rewrite result");
12111211

12121212
query= (Query*)linitial(rewritten);
1213-
Assert(query->commandType==CMD_SELECT);
1214-
Assert(query->utilityStmt==NULL);
12151213

1216-
/* Query mustn't use INTO, either */
1217-
if (query->intoClause)
1214+
/* The grammar allows SELECT INTO, but we don't support that */
1215+
if (query->utilityStmt!=NULL&&
1216+
IsA(query->utilityStmt,CreateTableAsStmt))
12181217
ereport(ERROR,
12191218
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
12201219
errmsg("COPY (SELECT INTO) is not supported")));
12211220

1221+
Assert(query->commandType==CMD_SELECT);
1222+
Assert(query->utilityStmt==NULL);
1223+
12221224
/* plan the query */
12231225
plan=planner(query,0,NULL);
12241226

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp