Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit9da3001

Browse files
committed
pg_upgrade: Fix some minor code issues
96ef3b8 accidentally copied a notapplicable comment from the float8_pass_by_value code to thedata_checksums code. Remove that.87d3b35 changed pg_upgrade tochecking the checksum version rather than just the Boolean presence ofchecksums, but didn't change the field type in its ControlData structfrom bool. So this would not work correctly if there ever is achecksum version larger than 1.
1 parentc040874 commit9da3001

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

‎src/bin/pg_upgrade/controldata.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,6 @@ get_control_data(ClusterInfo *cluster, bool live_check)
497497
pg_fatal("%d: controldata retrieval problem",__LINE__);
498498

499499
p++;/* remove ':' char */
500-
/* used later for contrib check */
501500
cluster->controldata.data_checksum_version=str2uint(p);
502501
got_data_checksum_version= true;
503502
}

‎src/bin/pg_upgrade/pg_upgrade.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ typedef struct
216216
uint32large_object;
217217
booldate_is_int;
218218
boolfloat8_pass_by_value;
219-
booldata_checksum_version;
219+
uint32data_checksum_version;
220220
}ControlData;
221221

222222
/*

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp