NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9d3ebba

committed

pgstat: Create memory contexts below TopMemoryContext

So far they were created below CacheMemoryContext. However, that's notguaranteed to exist in all situations, leading to memory contexts created astop-level contexts. There isn't actually a good reason anymore to create thembelow CacheMemoryContext, so just creating them below TopMemoryContext seemsthe best approach.Reported-by: Reid Thompson <reid.thompson@crunchydata.com>Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>Reviewed-by: Andres Freund <andres@anarazel.de>Author: "Drouvot, Bertrand" <bdrouvot@amazon.com>Discussion:https://postgr.es/m/b948b729-42fe-f88c-2f4a-0e65d84c049b@amazon.comBackpatch: 15-

1 parentfdd8937 commit9d3ebbaCopy full SHA for 9d3ebba

File tree

2 files changed

-3

lines changed

src/backend/utils/activity
- pgstat.c
- pgstat_shmem.c

2 files changed

-3

lines changed

`‎src/backend/utils/activity/pgstat.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1069,7 +1069,7 @@ pgstat_prep_pending_entry(PgStat_Kind kind, Oid dboid, Oid objoid, bool *created`
`1069`	`1069`	`if (unlikely(!pgStatPendingContext))`
`1070`	`1070`	`{`
`1071`	`1071`	`pgStatPendingContext=`
`1072`		`-AllocSetContextCreate(CacheMemoryContext,`
	`1072`	`+AllocSetContextCreate(TopMemoryContext,`
`1073`	`1073`	`"PgStat Pending",`
`1074`	`1074`	`ALLOCSET_SMALL_SIZES);`
`1075`	`1075`	`}`

`‎src/backend/utils/activity/pgstat_shmem.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -992,12 +992,12 @@ pgstat_setup_memcxt(void)`
`992`	`992`	`{`
`993`	`993`	`if (unlikely(!pgStatSharedRefContext))`
`994`	`994`	`pgStatSharedRefContext=`
`995`		`-AllocSetContextCreate(CacheMemoryContext,`
	`995`	`+AllocSetContextCreate(TopMemoryContext,`
`996`	`996`	`"PgStat Shared Ref",`
`997`	`997`	`ALLOCSET_SMALL_SIZES);`
`998`	`998`	`if (unlikely(!pgStatEntryRefHashContext))`
`999`	`999`	`pgStatEntryRefHashContext=`
`1000`		`-AllocSetContextCreate(CacheMemoryContext,`
	`1000`	`+AllocSetContextCreate(TopMemoryContext,`
`1001`	`1001`	`"PgStat Shared Ref Hash",`
`1002`	`1002`	`ALLOCSET_SMALL_SIZES);`
`1003`	`1003`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9d3ebba

File tree

2 files changed

2 files changed

`‎src/backend/utils/activity/pgstat.c`

`‎src/backend/utils/activity/pgstat_shmem.c`

0 commit comments