Commit9c75e1a

committed

Forbid parallel Hash Right Join or Hash Full Join.

That won't work. You'll get bogus null-extended rows.Mithun Cy

1 parentcfb863f commit9c75e1aCopy full SHA for 9c75e1a

File tree

-3

lines changed

-3

lines changed

Lines changed: 7 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1450,10 +1450,14 @@ hash_inner_and_outer(PlannerInfo *root,`
`1450`	`1450`	`* If the joinrel is parallel-safe, we may be able to consider a`
`1451`	`1451`	`* partial hash join. However, we can't handle JOIN_UNIQUE_OUTER,`
`1452`	`1452`	`* because the outer path will be partial, and therefore we won't be`
`1453`		`- * able to properly guarantee uniqueness. Also, the resulting path`
`1454`		`- * must not be parameterized.`
	`1453`	`+ * able to properly guarantee uniqueness. Similarly, we can't handle`
	`1454`	`+ * JOIN_FULL and JOIN_RIGHT, because they can produce false null`
	`1455`	`+ * extended rows. Also, the resulting path must not be parameterized.`
`1455`	`1456`	`*/`
`1456`		`-if (joinrel->consider_parallel&&jointype!=JOIN_UNIQUE_OUTER&&`
	`1457`	`+if (joinrel->consider_parallel&&`
	`1458`	`+jointype!=JOIN_UNIQUE_OUTER&&`
	`1459`	`+jointype!=JOIN_FULL&&`
	`1460`	`+jointype!=JOIN_RIGHT&&`
`1457`	`1461`	`outerrel->partial_pathlist!=NIL&&`
`1458`	`1462`	`bms_is_empty(joinrel->lateral_relids))`
`1459`	`1463`	`{`

Comments

(0)