NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9c73395

committed

Add fastpaths for when no objects are found

If there are no objects found, there is no reason to inspect theresult columns and mallocing a zero-sized (which will be 1 bytein reality) heap buffer for it. Add a fast-path for immediatelyreturning like how other object inspection functions are alreadydoing it.Reviewed-by: Ranier Vilela <ranier.vf@gmail.com>Discussion:https://postgr.es/m/C2F05B3C-1414-45DD-AE09-6FEE4D0F89BD@yesql.se

1 parent1a123e3 commit9c73395Copy full SHA for 9c73395

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_dump.c‎`

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4314,6 +4314,9 @@ getPublications(Archive *fout)`
`4314`	`4314`
`4315`	`4315`	`ntups = PQntuples(res);`
`4316`	`4316`
	`4317`	`+if (ntups == 0)`
	`4318`	`+goto cleanup;`
	`4319`	`+`
`4317`	`4320`	`i_tableoid = PQfnumber(res, "tableoid");`
`4318`	`4321`	`i_oid = PQfnumber(res, "oid");`
`4319`	`4322`	`i_pubname = PQfnumber(res, "pubname");`
`@@ -4352,6 +4355,8 @@ getPublications(Archive *fout)`
`4352`	`4355`	`/* Decide whether we want to dump it */`
`4353`	`4356`	`selectDumpableObject(&(pubinfo[i].dobj), fout);`
`4354`	`4357`	`}`
	`4358`	`+`
	`4359`	`+cleanup:`
`4355`	`4360`	`PQclear(res);`
`4356`	`4361`
`4357`	`4362`	`destroyPQExpBuffer(query);`
`@@ -5817,7 +5822,7 @@ getExtensions(Archive fout, int numExtensions)`
`5817`	`5822`	`intntups;`
`5818`	`5823`	`inti;`
`5819`	`5824`	`PQExpBuffer query;`
`5820`		`-ExtensionInfo *extinfo;`
	`5825`	`+ExtensionInfo *extinfo = NULL;`
`5821`	`5826`	`inti_tableoid;`
`5822`	`5827`	`inti_oid;`
`5823`	`5828`	`inti_extname;`
`@@ -5837,6 +5842,8 @@ getExtensions(Archive fout, int numExtensions)`
`5837`	`5842`	`res = ExecuteSqlQuery(fout, query->data, PGRES_TUPLES_OK);`
`5838`	`5843`
`5839`	`5844`	`ntups = PQntuples(res);`
	`5845`	`+if (ntups == 0)`
	`5846`	`+goto cleanup;`
`5840`	`5847`
`5841`	`5848`	`extinfo = (ExtensionInfo ) pg_malloc(ntups sizeof(ExtensionInfo));`
`5842`	`5849`
`@@ -5866,6 +5873,7 @@ getExtensions(Archive fout, int numExtensions)`
`5866`	`5873`	`selectDumpableExtension(&(extinfo[i]), dopt);`
`5867`	`5874`	`}`
`5868`	`5875`
	`5876`	`+cleanup:`
`5869`	`5877`	`PQclear(res);`
`5870`	`5878`	`destroyPQExpBuffer(query);`
`5871`	`5879`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9c73395

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c‎`

0 commit comments