NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9b7c56d

committed

Don't record FDW user mappings as members of extensions.

CreateUserMapping has a recordDependencyOnCurrentExtension call that'sbeen there since extensions were introduced (very possibly my fault).However, there's no support anywhere else for user mappings as membersof extensions, nor are they listed as a possible member object type inthe documentation. Nor does it really seem like a good idea for usermappings to belong to extensions when roles don't. Hence, remove thebogus call.(As we saw in bug #15310, the lack of any pg_dump support for this caseensures that any such membership record would silently disappear duringpg_upgrade. So there's probably no need for us to do anything elseabout cleaning up after this mistake.)Discussion:https://postgr.es/m/27952.1533667213@sss.pgh.pa.us

1 parent41db973 commit9b7c56dCopy full SHA for 9b7c56d

File tree

1 file changed

-2

lines changed

src/backend/commands
- foreigncmds.c

1 file changed

-2

lines changed

`‎src/backend/commands/foreigncmds.c‎`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1231,8 +1231,12 @@ CreateUserMapping(CreateUserMappingStmt *stmt)`
`1231`	`1231`	`recordDependencyOnOwner(UserMappingRelationId,umId,useId);`
`1232`	`1232`	`}`
`1233`	`1233`
`1234`		`-/* dependency on extension */`
`1235`		`-recordDependencyOnCurrentExtension(&myself, false);`
	`1234`	`+/*`
	`1235`	`+ * Perhaps someday there should be a recordDependencyOnCurrentExtension`
	`1236`	`+ * call here; but since roles aren't members of extensions, it seems like`
	`1237`	`+ * user mappings shouldn't be either. Note that the grammar and pg_dump`
	`1238`	`+ * would need to be extended too if we change this.`
	`1239`	`+ */`
`1236`	`1240`
`1237`	`1241`	`/* Post creation hook for new user mapping */`
`1238`	`1242`	`InvokeObjectPostCreateHook(UserMappingRelationId,umId,0);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9b7c56d

File tree

1 file changed

1 file changed

`‎src/backend/commands/foreigncmds.c‎`

0 commit comments