Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit9b7c56d

Browse files
committed
Don't record FDW user mappings as members of extensions.
CreateUserMapping has a recordDependencyOnCurrentExtension call that'sbeen there since extensions were introduced (very possibly my fault).However, there's no support anywhere else for user mappings as membersof extensions, nor are they listed as a possible member object type inthe documentation. Nor does it really seem like a good idea for usermappings to belong to extensions when roles don't. Hence, remove thebogus call.(As we saw in bug #15310, the lack of any pg_dump support for this caseensures that any such membership record would silently disappear duringpg_upgrade. So there's probably no need for us to do anything elseabout cleaning up after this mistake.)Discussion:https://postgr.es/m/27952.1533667213@sss.pgh.pa.us
1 parent41db973 commit9b7c56d

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

‎src/backend/commands/foreigncmds.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1231,8 +1231,12 @@ CreateUserMapping(CreateUserMappingStmt *stmt)
12311231
recordDependencyOnOwner(UserMappingRelationId,umId,useId);
12321232
}
12331233

1234-
/* dependency on extension */
1235-
recordDependencyOnCurrentExtension(&myself, false);
1234+
/*
1235+
* Perhaps someday there should be a recordDependencyOnCurrentExtension
1236+
* call here; but since roles aren't members of extensions, it seems like
1237+
* user mappings shouldn't be either. Note that the grammar and pg_dump
1238+
* would need to be extended too if we change this.
1239+
*/
12361240

12371241
/* Post creation hook for new user mapping */
12381242
InvokeObjectPostCreateHook(UserMappingRelationId,umId,0);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp