NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9aff4dc

committed

Don't search for volatile expr in find_em_expr_usable_for_sorting_rel

While prepare_sort_from_pathkeys has to be concerned about matching upa volatile expression to the proper tlist entry, we don't need to dothat in find_em_expr_usable_for_sorting_rel becausee such a sort willhave to be postponed anyway.Author: James ColemanReviewed-by: Tomas VondraBackpatch-through: 13Discussion:https://postgr.es/m/CAAaqYe8cK3g5CfLC4w7bs%3DhC0mSksZC%3DH5M8LSchj5e5OxpTAg%40mail.gmail.com

1 parentfac1b47 commit9aff4dcCopy full SHA for 9aff4dc

File tree

1 file changed

-23

lines changed

src/backend/optimizer/path
- equivclass.c

1 file changed

-23

lines changed

`‎src/backend/optimizer/path/equivclass.c`

Lines changed: 5 additions & 23 deletions

Original file line number	Diff line number	Diff line change
`@@ -816,8 +816,6 @@ find_em_expr_usable_for_sorting_rel(PlannerInfo root, EquivalenceClass ec,`
`816`	`816`	`{`
`817`	`817`	`EquivalenceMember*em=lfirst(lc_em);`
`818`	`818`	`Expr*em_expr=em->em_expr;`
`819`		`-PathTarget*target=rel->reltarget;`
`820`		`-ListCell*lc_target_expr;`
`821`	`819`
`822`	`820`	`/*`
`823`	`821`	`* We shouldn't be trying to sort by an equivalence class that`
`@@ -851,30 +849,14 @@ find_em_expr_usable_for_sorting_rel(PlannerInfo root, EquivalenceClass ec,`
`851`	`849`	`* As long as the expression isn't volatile then`
`852`	`850`	`* prepare_sort_from_pathkeys is able to generate a new target entry,`
`853`	`851`	`* so there's no need to verify that one already exists.`
	`852`	`+ *`
	`853`	`+ * While prepare_sort_from_pathkeys has to be concerned about matching`
	`854`	`+ * up a volatile expression to the proper tlist entry, it doesn't seem`
	`855`	`+ * valuable here to expend the work trying to find a match in the`
	`856`	`+ * target's exprs since such a sort will have to be postponed anyway.`
`854`	`857`	`*/`
`855`	`858`	`if (!ec->ec_has_volatile)`
`856`	`859`	`returnem->em_expr;`
`857`		`-`
`858`		`-/*`
`859`		`- * If, however, it's volatile, we have to verify that the`
`860`		`- * equivalence member's expr is already generated in the`
`861`		`- * relation's target (we do strip relabels first from both`
`862`		`- * expressions, which is cheap and might allow us to match`
`863`		`- * more expressions).`
`864`		`- */`
`865`		`-while (em_expr&&IsA(em_expr,RelabelType))`
`866`		`-em_expr= ((RelabelType*)em_expr)->arg;`
`867`		`-`
`868`		`-foreach(lc_target_expr,target->exprs)`
`869`		`-{`
`870`		`-Expr*target_expr=lfirst(lc_target_expr);`
`871`		`-`
`872`		`-while (target_expr&&IsA(target_expr,RelabelType))`
`873`		`-target_expr= ((RelabelType*)target_expr)->arg;`
`874`		`-`
`875`		`-if (equal(target_expr,em_expr))`
`876`		`-returnem->em_expr;`
`877`		`-}`
`878`	`860`	`}`
`879`	`861`
`880`	`862`	`/* We didn't find any suitable equivalence class expression */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9aff4dc

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/equivclass.c`

0 commit comments