NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9af67b6

committed

Avoid hot standby cancels from VAC FREEZE

VACUUM FREEZE generated false cancelations of standby queries on anotherwise idle master. Caused by an off-by-one error on cutoff_xidwhich goes back to original commit.Backpatch to all versions 9.0+Analysis and report by Marco NenciariniBug fix by Simon Riggs

1 parentb6c4b58 commit9af67b6Copy full SHA for 9af67b6

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -7517,7 +7517,13 @@ heap_xlog_freeze_page(XLogRecPtr lsn, XLogRecord *record)`
`7517`	`7517`	`* consider the frozen xids as running.`
`7518`	`7518`	`*/`
`7519`	`7519`	`if (InHotStandby)`
`7520`		`-ResolveRecoveryConflictWithSnapshot(cutoff_xid,xlrec->node);`
	`7520`	`+{`
	`7521`	`+TransactionIdlatestRemovedXid=cutoff_xid;`
	`7522`	`+`
	`7523`	`+TransactionIdRetreat(latestRemovedXid);`
	`7524`	`+`
	`7525`	`+ResolveRecoveryConflictWithSnapshot(latestRemovedXid,rnode);`
	`7526`	`+}`
`7521`	`7527`
`7522`	`7528`	`/* If we have a full-page image, restore it and we're done */`
`7523`	`7529`	`if (record->xl_info&XLR_BKP_BLOCK(0))`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9af67b6

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c`

0 commit comments