NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9a31256

committed

Fix object identity string for transforms

In commitad89a5d, we added an unhelpful 'ON' that doesn't matchthe input syntax. This was discovered while adding code to support forDDL in logical replication.No backpatch because of the change of behavior, however improbable itmay be that somebody is depending on this.Author: Zheng Li <zhengli10@gmail.com>Discussion:https://postgr.es/m/CAAD30UKg8rXeGM8Oy_MAmxKBL_K5DiHXdeNF=hUefcu1C_6VfQ@mail.gmail.com

1 parenta1acdac commit9a31256Copy full SHA for 9a31256

File tree

2 files changed

-2

lines changed

src
- backend/catalog
  - objectaddress.c
- test/regress/expected
  - object_address.out

2 files changed

-2

lines changed

`‎src/backend/catalog/objectaddress.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5922,7 +5922,7 @@ getObjectIdentityParts(const ObjectAddress *object,`
`5922`	`5922`	`transformType=format_type_be_qualified(transform->trftype);`
`5923`	`5923`	`transformLang=get_language_name(transform->trflang, false);`
`5924`	`5924`
`5925`		`-appendStringInfo(&buffer,"for %sonlanguage %s",`
	`5925`	`+appendStringInfo(&buffer,"for %s language %s",`
`5926`	`5926`	`transformType,`
`5927`	`5927`	`transformLang);`
`5928`	`5928`	`if (objname)`

`‎src/test/regress/expected/object_address.out`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -496,7 +496,7 @@ operator family\|pg_catalog\|integer_ops\|pg_catalog.integer_ops USING btree\|t`
`496`	`496`	`policy\|NULL\|NULL\|genpol on addr_nsp.gentable\|t`
`497`	`497`	`statistics object\|addr_nsp\|gentable_stat\|addr_nsp.gentable_stat\|t`
`498`	`498`	`collation\|pg_catalog\|"default"\|pg_catalog."default"\|t`
`499`		`-transform\|NULL\|NULL\|for integeronlanguage sql\|t`
	`499`	`+transform\|NULL\|NULL\|for integer language sql\|t`
`500`	`500`	`text search dictionary\|addr_nsp\|addr_ts_dict\|addr_nsp.addr_ts_dict\|t`
`501`	`501`	`text search parser\|addr_nsp\|addr_ts_prs\|addr_nsp.addr_ts_prs\|t`
`502`	`502`	`text search configuration\|addr_nsp\|addr_ts_conf\|addr_nsp.addr_ts_conf\|t`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9a31256

File tree

2 files changed

2 files changed

`‎src/backend/catalog/objectaddress.c`

`‎src/test/regress/expected/object_address.out`

0 commit comments