Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit99f6f19

Browse files
committed
Add missing test names in TAP tests of pg_upgrade
While on it, this removes the inclusion of getcwd() as The test codedoes not rely on it.Author: Peter EisentrautDiscussion:https://postgr.es/m/f80ace33-11fb-1cd3-20f8-98f51d151088@enterprisedb.com
1 parentdd1c8dd commit99f6f19

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

‎src/bin/pg_upgrade/t/002_pg_upgrade.pl

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
use strict;
33
use warnings;
44

5-
use Cwdqw(abs_path getcwd);
5+
use Cwdqw(abs_path);
66
use File::Basenameqw(dirname);
77
use File::Compare;
88

@@ -23,7 +23,9 @@ sub generate_db
2323
}
2424

2525
$dbname .=$suffix;
26-
$node->command_ok(['createdb',$dbname ]);
26+
$node->command_ok(
27+
['createdb',$dbname ],
28+
"created database with ASCII characters from$from_char to$to_char");
2729
}
2830

2931
# The test of pg_upgrade requires two clusters, an old one and a new one
@@ -71,7 +73,8 @@ sub generate_db
7173

7274
# Load the dump using the "postgres" database as "regression" does
7375
# not exist yet, and we are done here.
74-
$oldnode->command_ok(['psql','-X','-f',$olddumpfile,'postgres' ]);
76+
$oldnode->command_ok(['psql','-X','-f',$olddumpfile,'postgres' ],
77+
'loaded old dump file');
7578
}
7679
else
7780
{
@@ -136,7 +139,8 @@ sub generate_db
136139
'psql','-X',
137140
'-f',"$srcdir/src/bin/pg_upgrade/upgrade_adapt.sql",
138141
'regression'
139-
]);
142+
],
143+
'ran adapt script');
140144
}
141145

142146
# Initialize a new node for the upgrade.
@@ -233,7 +237,8 @@ sub generate_db
233237
'pg_dumpall','--no-sync',
234238
'-d',$newnode->connstr('postgres'),
235239
'-f',"$tempdir/dump2.sql"
236-
]);
240+
],
241+
'dump before running pg_upgrade');
237242

238243
# Compare the two dumps, there should be no differences.
239244
my$compare_res = compare("$tempdir/dump1.sql","$tempdir/dump2.sql");

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp