NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit99c01aa

committed

Clear errno before calling strtol() in spell.c.

Per POSIX, a caller of strtol() that wishes to check for errors mustset errno to 0 beforehand. Several places in spell.c neglected that,so that they risked delivering a false overflow error in case errnohad been ERANGE already. Given the lack of field reports, this casemay be unreachable at present --- but it's surely trouble waiting tohappen, so fix it.Author: Jacob Brazeal <jacob.brazeal@gmail.com>Discussion:https://postgr.es/m/CA+COZaBhsq6EromFm+knMJfzK6nTpG23zJ+K2=nfUQQXcj_xcQ@mail.gmail.comBackpatch-through: 13

1 parentc3510cf commit99c01aaCopy full SHA for 99c01aa

File tree

1 file changed

-0

lines changed

src/backend/tsearch
- spell.c

1 file changed

-0

lines changed

`‎src/backend/tsearch/spell.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -374,6 +374,7 @@ getNextFlagFromString(IspellDict Conf, char sflagset, char sflag)`
`374`	`374`	`stop= (maxstep==0);`
`375`	`375`	`break;`
`376`	`376`	`caseFM_NUM:`
	`377`	`+errno=0;`
`377`	`378`	`s=strtol(*sflagset,&next,10);`
`378`	`379`	`if (*sflagset==next\|\|errno==ERANGE)`
`379`	`380`	`ereport(ERROR,`
`@@ -1036,6 +1037,7 @@ setCompoundAffixFlagValue(IspellDict Conf, CompoundAffixFlag entry,`
`1036`	`1037`	`char*next;`
`1037`	`1038`	`inti;`
`1038`	`1039`
	`1040`	`+errno=0;`
`1039`	`1041`	`i=strtol(s,&next,10);`
`1040`	`1042`	`if (s==next\|\|errno==ERANGE)`
`1041`	`1043`	`ereport(ERROR,`
`@@ -1163,6 +1165,7 @@ getAffixFlagSet(IspellDict Conf, char s)`
`1163`	`1165`	`intcuraffix;`
`1164`	`1166`	`char*end;`
`1165`	`1167`
	`1168`	`+errno=0;`
`1166`	`1169`	`curaffix=strtol(s,&end,10);`
`1167`	`1170`	`if (s==end\|\|errno==ERANGE)`
`1168`	`1171`	`ereport(ERROR,`
`@@ -1735,6 +1738,7 @@ NISortDictionary(IspellDict *Conf)`
`1735`	`1738`
`1736`	`1739`	`if (*Conf->Spell[i]->p.flag!='\0')`
`1737`	`1740`	`{`
	`1741`	`+errno=0;`
`1738`	`1742`	`curaffix=strtol(Conf->Spell[i]->p.flag,&end,10);`
`1739`	`1743`	`if (Conf->Spell[i]->p.flag==end\|\|errno==ERANGE)`
`1740`	`1744`	`ereport(ERROR,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit99c01aa

File tree

1 file changed

1 file changed

`‎src/backend/tsearch/spell.c`

0 commit comments