NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit997db12

committed

Make GIN test using injection points repeatable

As written, the test would fail when run repeatedly because one of theinjection points attached was not detached. This would not matter ifthe test is rewritten to be concurrently safe, but let's be clean andit is a good practice.Oversight in6a1ea02.Discussion:https://postgr.es/m/ZfP7IDs9TvrKe49x@paquier.xyz

1 parent705ec05 commit997db12Copy full SHA for 997db12

File tree

2 files changed

-0

lines changed

src/test/modules/gin
- expected
  - gin_incomplete_splits.out
- sql
  - gin_incomplete_splits.sql

2 files changed

-0

lines changed

`‎src/test/modules/gin/expected/gin_incomplete_splits.out`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -179,3 +179,9 @@ select verify(:next_i);`
`179`	`179`	`t`
`180`	`180`	`(1 row)`
`181`	`181`
	`182`	`+SELECT injection_points_detach('gin-finish-incomplete-split');`
	`183`	`+ injection_points_detach`
	`184`	`+-------------------------`
	`185`	`+`
	`186`	`+(1 row)`
	`187`	`+`

`‎src/test/modules/gin/sql/gin_incomplete_splits.sql`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -143,3 +143,5 @@ select insert_n(:next_i, 10) as next_i`
`143`	`143`	`\gset`
`144`	`144`	`-- Verify that a scan still works`
`145`	`145`	`select verify(:next_i);`
	`146`	`+`
	`147`	`+SELECT injection_points_detach('gin-finish-incomplete-split');`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit997db12

File tree

2 files changed

2 files changed

`‎src/test/modules/gin/expected/gin_incomplete_splits.out`

`‎src/test/modules/gin/sql/gin_incomplete_splits.sql`

0 commit comments