NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit991dee2

committed

Rename pg_shdepend.c's typedef "objectType" to SharedDependencyObjectType.

The name objectType is widely used as a field name, and it's pure luck thatthis conflict has not caused pgindent to go crazy before. It messed uppg_audit.c pretty good though. Since pg_shdepend.c doesn't export thistypedef and only uses it in three places, changing that seems saner thanchanging the field usages.Back-patch because we're contemplating using the union of all branchtypedefs for future pgindent runs, so this won't fix anything if itstays the same in back branches.

1 parent4dddf85 commit991dee2Copy full SHA for 991dee2

File tree

1 file changed

-3

lines changed

src/backend/catalog
- pg_shdepend.c

1 file changed

-3

lines changed

`‎src/backend/catalog/pg_shdepend.c`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ typedef enum`
`58`	`58`	`LOCAL_OBJECT,`
`59`	`59`	`SHARED_OBJECT,`
`60`	`60`	`REMOTE_OBJECT`
`61`		`-}objectType;`
	`61`	`+}SharedDependencyObjectType;`
`62`	`62`
`63`	`63`	`staticvoidgetOidListDiff(Oidlist1,intnlist1,Oidlist2,intnlist2);`
`64`	`64`	`staticOidclassIdGetDbId(OidclassId);`
`@@ -75,7 +75,8 @@ static void shdepDropDependency(Relation sdepRel,`
`75`	`75`	`booldrop_subobjects,`
`76`	`76`	`OidrefclassId,OidrefobjId,`
`77`	`77`	`SharedDependencyTypedeptype);`
`78`		`-staticvoidstoreObjectDescription(StringInfodescs,objectTypetype,`
	`78`	`+staticvoidstoreObjectDescription(StringInfodescs,`
	`79`	`+SharedDependencyObjectTypetype,`
`79`	`80`	`ObjectAddress*object,`
`80`	`81`	`SharedDependencyTypedeptype,`
`81`	`82`	`intcount);`
`@@ -1053,7 +1054,8 @@ shdepLockAndCheckObject(Oid classId, Oid objectId)`
`1053`	`1054`	`* and count to be nonzero; deptype is not used in this case.`
`1054`	`1055`	`*/`
`1055`	`1056`	`staticvoid`
`1056`		`-storeObjectDescription(StringInfodescs,objectTypetype,`
	`1057`	`+storeObjectDescription(StringInfodescs,`
	`1058`	`+SharedDependencyObjectTypetype,`
`1057`	`1059`	`ObjectAddress*object,`
`1058`	`1060`	`SharedDependencyTypedeptype,`
`1059`	`1061`	`intcount)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit991dee2

File tree

1 file changed

1 file changed

`‎src/backend/catalog/pg_shdepend.c`

0 commit comments