NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9903338

committed

Remove dry-run mode from isolationtester

The original purpose of the dry-run mode is to be able to print all thepossible permutations from a spec file, but it has become less usefulsince isolation tests has improved regarding deadlock detection as onestep not wanted by the author could block indefinitely now (originallythe step blocked would have been detected rather quickly). Perdiscussion, let's remove it.Author: Michael PaquierReviewed-by: Asim Praveen, Melanie PlagemanDiscussion:https://postgr.es/m/20190819080820.GG18166@paquier.xyz

1 parent292ae8a commit9903338Copy full SHA for 9903338

File tree

1 file changed

-30

lines changed

src/test/isolation
- isolationtester.c

1 file changed

-30

lines changed

`‎src/test/isolation/isolationtester.c`

Lines changed: 1 addition & 30 deletions

Original file line number	Diff line number	Diff line change
`@@ -31,9 +31,6 @@ static int *backend_pids = NULL;`
`31`	`31`	`staticconstchar**backend_pid_strs=NULL;`
`32`	`32`	`staticintnconns=0;`
`33`	`33`
`34`		`-/* In dry run only output permutations to be run by the tester. */`
`35`		`-staticintdry_run= false;`
`36`		`-`
`37`	`34`	`staticvoidrun_testspec(TestSpec*testspec);`
`38`	`35`	`staticvoidrun_all_permutations(TestSpec*testspec);`
`39`	`36`	`staticvoidrun_all_permutations_recurse(TestSpec*testspec,intnsteps,`
`@@ -76,13 +73,10 @@ main(int argc, char **argv)`
`76`	`73`	`intnallsteps;`
`77`	`74`	`Step**allsteps;`
`78`	`75`
`79`		`-while ((opt=getopt(argc,argv,"nV"))!=-1)`
	`76`	`+while ((opt=getopt(argc,argv,"V"))!=-1)`
`80`	`77`	`{`
`81`	`78`	`switch (opt)`
`82`	`79`	`{`
`83`		`-case'n':`
`84`		`-dry_run= true;`
`85`		`-break;`
`86`	`80`	`case'V':`
`87`	`81`	`puts("isolationtester (PostgreSQL) "PG_VERSION);`
`88`	`82`	`exit(0);`
`@@ -144,16 +138,6 @@ main(int argc, char **argv)`
`144`	`138`	`}`
`145`	`139`	`}`
`146`	`140`
`147`		`-/*`
`148`		`- * In dry-run mode, just print the permutations that would be run, and`
`149`		`- * exit.`
`150`		`- */`
`151`		`-if (dry_run)`
`152`		`-{`
`153`		`-run_testspec(testspec);`
`154`		`-return0;`
`155`		`-}`
`156`		`-`
`157`	`141`	`printf("Parsed test spec with %d sessions\n",testspec->nsessions);`
`158`	`142`
`159`	`143`	`/*`
`@@ -449,19 +433,6 @@ run_permutation(TestSpec testspec, int nsteps, Step *steps)`
`449`	`433`	`Step**waiting;`
`450`	`434`	`Step**errorstep;`
`451`	`435`
`452`		`-/*`
`453`		`- * In dry run mode, just display the permutation in the same format used`
`454`		`- * by spec files, and return.`
`455`		`- */`
`456`		`-if (dry_run)`
`457`		`-{`
`458`		`-printf("permutation");`
`459`		`-for (i=0;i<nsteps;i++)`
`460`		`-printf(" \"%s\"",steps[i]->name);`
`461`		`-printf("\n");`
`462`		`-return;`
`463`		`-}`
`464`		`-`
`465`	`436`	`waiting=pg_malloc(sizeof(Step)testspec->nsessions);`
`466`	`437`	`errorstep=pg_malloc(sizeof(Step)testspec->nsessions);`
`467`	`438`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9903338

File tree

1 file changed

1 file changed

`‎src/test/isolation/isolationtester.c`

0 commit comments