NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit987db50

committed

On second thought, remove regex.linux.utf8 regression test altogether.

The code-coverage report says that this test doesn't increasecoverage by one single line, which I now realize is becauseI made src/test/modules/test_regex/sql/test_regex_utf8.sqlto cover all the code that this would. So really it's pointlessand we should just drop it.

1 parent72a3ebf commit987db50Copy full SHA for 987db50

File tree

4 files changed

-237

lines changed

src/test/regress
- expected
  - regex.linux.utf8.out
  - regex.linux.utf8_1.out
- parallel_schedule
- sql
  - regex.linux.utf8.sql

4 files changed

-237

lines changed

`‎src/test/regress/expected/regex.linux.utf8.out‎`

Lines changed: 0 additions & 171 deletions

This file was deleted.

`‎src/test/regress/expected/regex.linux.utf8_1.out‎`

Lines changed: 0 additions & 11 deletions

This file was deleted.

`‎src/test/regress/parallel_schedule‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ test: create_table_like alter_generic alter_operator misc async dbsize misc_func`
`94`	`94`	`# rules cannot run concurrently with any test that creates`
`95`	`95`	`# a view or rule in the public schema`
`96`	`96`	`# collate.*.utf8 tests cannot be run in parallel with each other`
`97`		`-test: rules psql psql_crosstab amutils stats_ext collate.linux.utf8 regex.linux.utf8`
	`97`	`+test: rules psql psql_crosstab amutils stats_ext collate.linux.utf8`
`98`	`98`
`99`	`99`	`# run by itself so it can run parallel workers`
`100`	`100`	`test: select_parallel`

`‎src/test/regress/sql/regex.linux.utf8.sql‎`

Lines changed: 0 additions & 54 deletions

This file was deleted.

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit987db50

File tree

4 files changed

4 files changed

`‎src/test/regress/expected/regex.linux.utf8.out‎`

`‎src/test/regress/expected/regex.linux.utf8_1.out‎`

`‎src/test/regress/parallel_schedule‎`

`‎src/test/regress/sql/regex.linux.utf8.sql‎`

0 commit comments