NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit986127e

committed

Avoid unportable shell syntax in pg_upgrade's test script.

Most of test.sh uses traditional backtick syntax for command substitution,but commitda9b580 introduced two uses of $(...) syntax, which is notrecognized by very old shells. Bring those into line with the rest.Victor WagnerDiscussion:https://postgr.es/m/20180720153820.69e9ae6c@fafnir.local.vm

1 parent8f6ce7f commit986127eCopy full SHA for 986127e

File tree

1 file changed

-2

lines changed

src/bin/pg_upgrade
- test.sh

1 file changed

-2

lines changed

`‎src/bin/pg_upgrade/test.sh`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -234,15 +234,15 @@ pg_upgrade $PG_UPGRADE_OPTS -d "${PGDATA}.old" -D "${PGDATA}" -b "$oldbindir" -B`
`234`	`234`	`# Windows hosts don't support Unix-y permissions.`
`235`	`235`	`case$testhostin`
`236`	`236`	`MINGW*) ;;`
`237`		`-*)if [$(find${PGDATA} -type f! -perm 640\| wc -l)-ne 0 ];then`
	`237`	+*)if [`find${PGDATA} -type f! -perm 640\| wc -l`-ne 0 ];then
`238`	`238`	`echo"files in PGDATA with permission != 640";`
`239`	`239`	`exit 1;`
`240`	`240`	`fi ;;`
`241`	`241`	`esac`
`242`	`242`
`243`	`243`	`case$testhostin`
`244`	`244`	`MINGW*) ;;`
`245`		`-*)if [$(find${PGDATA} -type d! -perm 750\| wc -l)-ne 0 ];then`
	`245`	+*)if [`find${PGDATA} -type d! -perm 750\| wc -l`-ne 0 ];then
`246`	`246`	`echo"directories in PGDATA with permission != 750";`
`247`	`247`	`exit 1;`
`248`	`248`	`fi ;;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit986127e

File tree

1 file changed

1 file changed

`‎src/bin/pg_upgrade/test.sh`

0 commit comments