NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit983ec2c

committed

Make parser functions static where possible.

1 parentb704426 commit983ec2cCopy full SHA for 983ec2c

File tree

3 files changed

+13

-22

lines changed

src
- backend
  - executor
    - execQual.c
  - utils/time
    - tqual.c
- include/executor
  - executor.h

3 files changed

+13

-22

lines changed

`‎src/backend/executor/execQual.c`

Lines changed: 7 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/executor/execQual.c,v 1.19 1997/09/27 14:37:10 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/executor/execQual.c,v 1.20 1997/11/26 03:54:00 momjian Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -70,24 +70,19 @@ intexecConstLen;`
`70`	`70`
`71`	`71`	`/* static functions decls */`
`72`	`72`	`staticDatumExecEvalAggreg(Aggregagg,ExprContextecontext,bool*isNull);`
`73`		`-staticDatum`
`74`		`-ExecEvalArrayRef(ArrayRefarrayRef,ExprContextecontext,`
	`73`	`+staticDatumExecEvalArrayRef(ArrayRefarrayRef,ExprContextecontext,`
`75`	`74`	`boolisNull,boolisDone);`
`76`	`75`	`staticDatumExecEvalAnd(ExprandExpr,ExprContextecontext,bool*isNull);`
`77`		`-staticDatum`
`78`		`-ExecEvalFunc(ExprfuncClause,ExprContextecontext,`
	`76`	`+staticDatumExecEvalFunc(ExprfuncClause,ExprContextecontext,`
`79`	`77`	`boolisNull,boolisDone);`
`80`		`-staticvoid`
`81`		`-ExecEvalFuncArgs(FunctionCachePtrfcache,ExprContext*econtext,`
	`78`	`+staticvoidExecEvalFuncArgs(FunctionCachePtrfcache,ExprContext*econtext,`
`82`	`79`	`ListargList,DatumargV[],boolargIsDone);`
`83`	`80`	`staticDatumExecEvalNot(Exprnotclause,ExprContextecontext,bool*isNull);`
`84`		`-staticDatum`
`85`		`-ExecEvalOper(ExpropClause,ExprContextecontext,`
	`81`	`+staticDatumExecEvalOper(ExpropClause,ExprContextecontext,`
`86`	`82`	`bool*isNull);`
`87`	`83`	`staticDatumExecEvalOr(ExprorExpr,ExprContextecontext,bool*isNull);`
`88`	`84`	`staticDatumExecEvalVar(Varvariable,ExprContextecontext,bool*isNull);`
`89`		`-staticDatum`
`90`		`-ExecMakeFunctionResult(Nodenode,Listarguments,`
	`85`	`+staticDatumExecMakeFunctionResult(Nodenode,Listarguments,`
`91`	`86`	`ExprContextecontext,boolisNull,bool*isDone);`
`92`	`87`	`staticboolExecQualClause(Nodeclause,ExprContextecontext);`
`93`	`88`
`@@ -506,10 +501,7 @@ ExecEvalParam(Param expression, ExprContext econtext, bool *isNull)`
`506`	`501`	`*to use this. Ex: overpaid(EMP) might call GetAttributeByNum().`
`507`	`502`	`* ----------------`
`508`	`503`	`*/`
`509`		`-/*`
`510`		`- * This gets called from external functions, so don't make it static`
`511`		`- * or remove it`
`512`		`- */`
	`504`	`+/* static but gets called from external functions */`
`513`	`505`	`char*`
`514`	`506`	`GetAttributeByNum(TupleTableSlot*slot,`
`515`	`507`	`AttrNumberattrno,`

`‎src/backend/utils/time/tqual.c`

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/utils/time/tqual.c,v 1.12 1997/11/26 03:42:58 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/time/tqual.c,v 1.13 1997/11/26 03:54:18 momjian Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -24,8 +24,6 @@`
`24`	`24`	`#include"utils/palloc.h"`
`25`	`25`	`#include"utils/tqual.h"`
`26`	`26`
`27`		`-staticboolheapisoverride(void);`
`28`		`-`
`29`	`27`	`externboolPostgresIsInitialized;`
`30`	`28`
`31`	`29`	`/*`
`@@ -51,7 +49,8 @@ setheapoverride(bool on)`
`51`	`49`	`}`
`52`	`50`	`}`
`53`	`51`
`54`		`-staticbool`
	`52`	`+/* static, but called in debug macro */`
	`53`	`+bool`
`55`	`54`	`heapisoverride()`
`56`	`55`	`{`
`57`	`56`	`if (!TransactionIdIsValid(HeapSpecialTransactionId))`

`‎src/include/executor/executor.h`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`*`
`7`	`7`	`* Copyright (c) 1994, Regents of the University of California`
`8`	`8`	`*`
`9`		`- * $Id: executor.h,v 1.15 1997/11/20 23:23:39 momjian Exp $`
	`9`	`+ * $Id: executor.h,v 1.16 1997/11/26 03:54:23 momjian Exp $`
`10`	`10`	`*`
`11`	`11`	`*-------------------------------------------------------------------------`
`12`	`12`	`*/`
`@@ -79,8 +79,8 @@ ExecEvalParam(Param expression, ExprContext econtext,`
`79`	`79`	`bool*isNull);`
`80`	`80`
`81`	`81`	`/* stop here */`
`82`		`-externchar*`
`83`		`-GetAttributeByNum(TupleTableSlotslot,AttrNumberattrno,boolisNull);`
	`82`	`+externcharGetAttributeByNum(TupleTableSlotslot,AttrNumberattrno,`
	`83`	`+bool*isNull);`
`84`	`84`	`externchar*`
`85`	`85`	`GetAttributeByName(TupleTableSlotslot,charattname,bool*isNull);`
`86`	`86`	`externDatum`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit983ec2c

File tree

3 files changed

3 files changed

`‎src/backend/executor/execQual.c`

`‎src/backend/utils/time/tqual.c`

`‎src/include/executor/executor.h`

0 commit comments