NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit98170fa

committed

Declare mkdtemp() only if we're providing it.

Follow our usual style of providing an "extern" for a standard libraryfunction only when we're also providing the implementation. This avoidsissues when the system headers declare the function slightly differentlythan we do, as noted by Caleb Welton.We might have to go to the extent of probing to see if the system headersdeclare the function, but let's not do that until it's demonstrated to benecessary.Oversight in commit9e6b1bf. Back-patchto all supported branches, as that was.

1 parent31021e7 commit98170faCopy full SHA for 98170fa

File tree

1 file changed

-3

lines changed

src/include
- port.h

1 file changed

-3

lines changed

`‎src/include/port.h`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -403,6 +403,10 @@ extern intgetopt(int nargc, char const nargv, const char *ostr);`
`403`	`403`	`externintisinf(doublex);`
`404`	`404`	`#endif`
`405`	`405`
	`406`	`+#ifndefHAVE_MKDTEMP`
	`407`	`+externcharmkdtemp(charpath);`
	`408`	`+#endif`
	`409`	`+`
`406`	`410`	`#ifndefHAVE_RINT`
`407`	`411`	`externdoublerint(doublex);`
`408`	`412`	`#endif`
`@@ -464,7 +468,4 @@ extern void qsort_arg(void *base, size_t nel, size_t elsize,`
`464`	`468`	`/* port/chklocale.c */`
`465`	`469`	`externintpg_get_encoding_from_locale(constchar*ctype);`
`466`	`470`
`467`		`-/* port/mkdtemp.c */`
`468`		`-externcharmkdtemp(charpath);`
`469`		`-`
`470`	`471`	`#endif/* PG_PORT_H */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit98170fa

File tree

1 file changed

1 file changed

`‎src/include/port.h`

0 commit comments