Commit980c24e

committed

Check for NULL result from strdup

Per Coverity Scan

1 parent5fbc313 commit980c24eCopy full SHA for 980c24e

File tree

+11

-1

lines changed

+11

-1

lines changed

Lines changed: 11 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1132,7 +1132,17 @@ initialize_SSL(PGconn *conn)`
`1132`	`1132`	`{`
`1133`	`1133`	`/* Colon, but not in second character, treat as engine:key */`
`1134`	`1134`	`char*engine_str=strdup(conn->sslkey);`
`1135`		`-char*engine_colon=strchr(engine_str,':');`
	`1135`	`+char*engine_colon;`
	`1136`	`+`
	`1137`	`+if (engine_str==NULL)`
	`1138`	`+{`
	`1139`	`+printfPQExpBuffer(&conn->errorMessage,`
	`1140`	`+libpq_gettext("out of memory\n"));`
	`1141`	`+return-1;`
	`1142`	`+}`
	`1143`	`+`
	`1144`	`+/* cannot return NULL because we already checked before strdup */`
	`1145`	`+engine_colon=strchr(engine_str,':');`
`1136`	`1146`
`1137`	`1147`	`engine_colon='\0';/ engine_str now has engine name */`
`1138`	`1148`	`engine_colon++;/* engine_colon now has key name */`

Comments

(0)