NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit97b6f2e

committed

Remove tests for pg_dumpall --exclude-database missing argument

It turns out that different getopt implementations spell the error formissing arguments different ways. This test is of fairly marginalvalue, so instead of trying to keep up with the different errormessages just remove the test.

1 parentad0bda5 commit97b6f2eCopy full SHA for 97b6f2e

File tree

1 file changed

-6

lines changed

src/bin/pg_dump/t
- 001_basic.pl

1 file changed

-6

lines changed

`‎src/bin/pg_dump/t/001_basic.pl`

Lines changed: 1 addition & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`use Config;`
`5`	`5`	`use PostgresNode;`
`6`	`6`	`use TestLib;`
`7`		`-use Test::Moretests=>74;`
	`7`	`+use Test::Moretests=>72;`
`8`	`8`
`9`	`9`	`my$tempdir = TestLib::tempdir;`
`10`	`10`	`my$tempdir_short = TestLib::tempdir_short;`
`@@ -151,11 +151,6 @@`
`151`	`151`	`'pg_restore: options -C\/--create and -1\/--single-transaction cannot be used together'`
`152`	`152`	`);`
`153`	`153`
`154`		`-command_fails_like(`
`155`		`-['pg_dumpall','--exclude-database' ],`
`156`		`-qr/\Qpg_dumpall: option '--exclude-database' requires an argument\E/,`
`157`		`-'pg_dumpall: option --exclude-database requires an argument');`
`158`		`-`
`159`	`154`	`# also fails for -r and -t, but it seems pointless to add more tests for those.`
`160`	`155`	`command_fails_like(`
`161`	`156`	`['pg_dumpall','--exclude-database=foo','--globals-only' ],`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit97b6f2e

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/t/001_basic.pl`

0 commit comments