Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit961bf59

Browse files
committed
Rename wal_log_hintbits to wal_log_hints, per discussion on pgsql-hackers.
Sawada Masahiko
1 parent6130208 commit961bf59

File tree

10 files changed

+22
-22
lines changed

10 files changed

+22
-22
lines changed

‎doc/src/sgml/config.sgml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1957,10 +1957,10 @@ include 'filename'
19571957
</listitem>
19581958
</varlistentry>
19591959

1960-
<varlistentry id="guc-wal-log-hintbits" xreflabel="wal_log_hintbits">
1961-
<term><varname>wal_log_hintbits</varname> (<type>boolean</type>)</term>
1960+
<varlistentry id="guc-wal-log-hints" xreflabel="wal_log_hints">
1961+
<term><varname>wal_log_hints</varname> (<type>boolean</type>)</term>
19621962
<indexterm>
1963-
<primary><varname>wal_log_hintbits</> configuration parameter</primary>
1963+
<primary><varname>wal_log_hints</> configuration parameter</primary>
19641964
</indexterm>
19651965
<listitem>
19661966
<para>

‎src/backend/access/heap/visibilitymap.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ visibilitymap_set(Relation rel, BlockNumber heapBlk, Buffer heapBuf,
287287
cutoff_xid);
288288

289289
/*
290-
* If data checksums are enabled (orwal_log_hintbits=on), we
290+
* If data checksums are enabled (orwal_log_hints=on), we
291291
* need to protect the heap page from being torn.
292292
*/
293293
if (XLogHintBitIsNeeded())

‎src/backend/access/transam/xlog.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ boolXLogArchiveMode = false;
7979
char*XLogArchiveCommand=NULL;
8080
boolEnableHotStandby= false;
8181
boolfullPageWrites= true;
82-
boolwalLogHintbits= false;
82+
boolwalLogHints= false;
8383
boollog_checkpoints= false;
8484
intsync_method=DEFAULT_SYNC_METHOD;
8585
intwal_level=WAL_LEVEL_MINIMAL;
@@ -5271,7 +5271,7 @@ BootStrapXLOG(void)
52715271
ControlFile->max_prepared_xacts=max_prepared_xacts;
52725272
ControlFile->max_locks_per_xact=max_locks_per_xact;
52735273
ControlFile->wal_level=wal_level;
5274-
ControlFile->wal_log_hintbits=walLogHintbits;
5274+
ControlFile->wal_log_hints=walLogHints;
52755275
ControlFile->data_checksum_version=bootstrap_data_checksum_version;
52765276

52775277
/* some additional ControlFile fields are set in WriteControlFile() */
@@ -9060,7 +9060,7 @@ static void
90609060
XLogReportParameters(void)
90619061
{
90629062
if (wal_level!=ControlFile->wal_level||
9063-
walLogHintbits!=ControlFile->wal_log_hintbits||
9063+
walLogHints!=ControlFile->wal_log_hints||
90649064
MaxConnections!=ControlFile->MaxConnections||
90659065
max_worker_processes!=ControlFile->max_worker_processes||
90669066
max_prepared_xacts!=ControlFile->max_prepared_xacts||
@@ -9083,7 +9083,7 @@ XLogReportParameters(void)
90839083
xlrec.max_prepared_xacts=max_prepared_xacts;
90849084
xlrec.max_locks_per_xact=max_locks_per_xact;
90859085
xlrec.wal_level=wal_level;
9086-
xlrec.wal_log_hintbits=walLogHintbits;
9086+
xlrec.wal_log_hints=walLogHints;
90879087

90889088
rdata.buffer=InvalidBuffer;
90899089
rdata.data= (char*)&xlrec;
@@ -9098,7 +9098,7 @@ XLogReportParameters(void)
90989098
ControlFile->max_prepared_xacts=max_prepared_xacts;
90999099
ControlFile->max_locks_per_xact=max_locks_per_xact;
91009100
ControlFile->wal_level=wal_level;
9101-
ControlFile->wal_log_hintbits=walLogHintbits;
9101+
ControlFile->wal_log_hints=walLogHints;
91029102
UpdateControlFile();
91039103
}
91049104
}
@@ -9485,7 +9485,7 @@ xlog_redo(XLogRecPtr lsn, XLogRecord *record)
94859485
ControlFile->max_prepared_xacts=xlrec.max_prepared_xacts;
94869486
ControlFile->max_locks_per_xact=xlrec.max_locks_per_xact;
94879487
ControlFile->wal_level=xlrec.wal_level;
9488-
ControlFile->wal_log_hintbits=walLogHintbits;
9488+
ControlFile->wal_log_hints=walLogHints;
94899489

94909490
/*
94919491
* Update minRecoveryPoint to ensure that if recovery is aborted, we

‎src/backend/utils/misc/guc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -872,11 +872,11 @@ static struct config_bool ConfigureNamesBool[] =
872872
},
873873

874874
{
875-
{"wal_log_hintbits",PGC_POSTMASTER,WAL_SETTINGS,
875+
{"wal_log_hints",PGC_POSTMASTER,WAL_SETTINGS,
876876
gettext_noop("Writes full pages to WAL when first modified after a checkpoint, even for a non-critical modifications"),
877877
NULL
878878
},
879-
&walLogHintbits,
879+
&walLogHints,
880880
false,
881881
NULL,NULL,NULL
882882
},

‎src/backend/utils/misc/postgresql.conf.sample

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@
184184
# fsync_writethrough
185185
# open_sync
186186
#full_page_writes = on# recover from partial page writes
187-
#wal_log_hintbits = off# also do full pages writes of non-critical updates
187+
#wal_log_hints = off# also do full pages writes of non-critical updates
188188
#wal_buffers = -1# min 32kB, -1 sets based on shared_buffers
189189
# (change requires restart)
190190
#wal_writer_delay = 200ms# 1-10000 milliseconds

‎src/bin/pg_controldata/pg_controldata.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,8 +260,8 @@ main(int argc, char *argv[])
260260
ControlFile.backupEndRequired ?_("yes") :_("no"));
261261
printf(_("Current wal_level setting: %s\n"),
262262
wal_level_str(ControlFile.wal_level));
263-
printf(_("Currentwal_log_hintbits setting: %s\n"),
264-
ControlFile.wal_log_hintbits ?_("on") :_("off"));
263+
printf(_("Currentwal_log_hints setting: %s\n"),
264+
ControlFile.wal_log_hints ?_("on") :_("off"));
265265
printf(_("Current max_connections setting: %d\n"),
266266
ControlFile.MaxConnections);
267267
printf(_("Current max_worker_processes setting: %d\n"),

‎src/bin/pg_resetxlog/pg_resetxlog.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@ GuessControlValues(void)
525525
/* minRecoveryPoint, backupStartPoint and backupEndPoint can be left zero */
526526

527527
ControlFile.wal_level=WAL_LEVEL_MINIMAL;
528-
ControlFile.wal_log_hintbits= false;
528+
ControlFile.wal_log_hints= false;
529529
ControlFile.MaxConnections=100;
530530
ControlFile.max_worker_processes=8;
531531
ControlFile.max_prepared_xacts=0;
@@ -722,7 +722,7 @@ RewriteControlFile(void)
722722
* anyway at startup.
723723
*/
724724
ControlFile.wal_level=WAL_LEVEL_MINIMAL;
725-
ControlFile.wal_log_hintbits= false;
725+
ControlFile.wal_log_hints= false;
726726
ControlFile.MaxConnections=100;
727727
ControlFile.max_worker_processes=8;
728728
ControlFile.max_prepared_xacts=0;

‎src/include/access/xlog.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ extern bool XLogArchiveMode;
189189
externchar*XLogArchiveCommand;
190190
externboolEnableHotStandby;
191191
externboolfullPageWrites;
192-
externboolwalLogHintbits;
192+
externboolwalLogHints;
193193
externboollog_checkpoints;
194194
externintnum_xloginsert_slots;
195195

@@ -219,9 +219,9 @@ extern intwal_level;
219219
* we have to protect them against torn page writes. When you only set
220220
* individual bits on a page, it's still consistent no matter what combination
221221
* of the bits make it to disk, but the checksum wouldn't match. Also WAL-log
222-
* them if forced bywal_log_hintbits=on.
222+
* them if forced bywal_log_hints=on.
223223
*/
224-
#defineXLogHintBitIsNeeded() (DataChecksumsEnabled() ||walLogHintbits)
224+
#defineXLogHintBitIsNeeded() (DataChecksumsEnabled() ||walLogHints)
225225

226226
/* Do we need to WAL-log information required only for Hot Standby and logical replication? */
227227
#defineXLogStandbyInfoActive() (wal_level >= WAL_LEVEL_HOT_STANDBY)

‎src/include/access/xlog_internal.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ typedef struct xl_parameter_change
209209
intmax_prepared_xacts;
210210
intmax_locks_per_xact;
211211
intwal_level;
212-
boolwal_log_hintbits;
212+
boolwal_log_hints;
213213
}xl_parameter_change;
214214

215215
/* logs restore point */

‎src/include/catalog/pg_control.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ typedef struct ControlFileData
171171
* or hot standby.
172172
*/
173173
intwal_level;
174-
boolwal_log_hintbits;
174+
boolwal_log_hints;
175175
intMaxConnections;
176176
intmax_worker_processes;
177177
intmax_prepared_xacts;

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp