NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit96139cf

committed

Avoid core dump in _outPathInfo() for Path without a parent RelOptInfo.

Nearly all Paths have parents, but a ResultPath representing an empty FROMclause does not. Avoid a core dump in such cases. I believe this is onlya hazard for debugging usage, not for production, else we'd have heardabout it before. Nonetheless, back-patch to 9.1 where the troublesome codewas introduced. Noted while poking at bug #11703.

1 parent0c9391e commit96139cfCopy full SHA for 96139cf

File tree

1 file changed

-1

lines changed

src/backend/nodes
- outfuncs.c

1 file changed

-1

lines changed

`‎src/backend/nodes/outfuncs.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1466,7 +1466,10 @@ _outPathInfo(StringInfo str, Path *node)`
`1466`	`1466`	`{`
`1467`	`1467`	`WRITE_ENUM_FIELD(pathtype,NodeTag);`
`1468`	`1468`	`appendStringInfo(str," :parent_relids ");`
`1469`		`-_outBitmapset(str,node->parent->relids);`
	`1469`	`+if (node->parent)`
	`1470`	`+_outBitmapset(str,node->parent->relids);`
	`1471`	`+else`
	`1472`	`+_outBitmapset(str,NULL);`
`1470`	`1473`	`WRITE_FLOAT_FIELD(startup_cost,"%.2f");`
`1471`	`1474`	`WRITE_FLOAT_FIELD(total_cost,"%.2f");`
`1472`	`1475`	`WRITE_NODE_FIELD(pathkeys);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit96139cf

File tree

1 file changed

1 file changed

`‎src/backend/nodes/outfuncs.c`

0 commit comments