NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit95e28b7

committed

Fix over-aggressive sanity check in misc_sanity.sql.

Fix thinko in commit8be8510: it's okay to have dbid == 0 in normal(non-pin) entries in pg_shdepend, because global objects such asdatabases are entered that way. The test would pass so long as itwas run in a cluster containing no databases/tablespaces owned by,or granted to, roles other than the bootstrap superuser. That's theexpected situation for "make check", but for "make installcheck", notso much.Reported by Ryan Murphy.Discussion:https://postgr.es/m/CAHeEsBc6EQe0mxGBKDXAwJbntgfvoAd5MQC-5362SmC3Tng_6g@mail.gmail.com

1 parent46596f8 commit95e28b7Copy full SHA for 95e28b7

File tree

2 files changed

-2

lines changed

src/test/regress
- expected
  - misc_sanity.out
- sql
  - misc_sanity.sql

2 files changed

-2

lines changed

`‎src/test/regress/expected/misc_sanity.out`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ SELECT *`
`29`	`29`	`FROM pg_shdepend as d1`
`30`	`30`	`WHERE refclassid = 0 OR refobjid = 0 OR`
`31`	`31`	`deptype NOT IN ('a', 'o', 'p', 'r') OR`
`32`		`- (deptype != 'p' AND (dbid = 0 ORclassid = 0 OR objid = 0)) OR`
	`32`	`+ (deptype != 'p' AND (classid = 0 OR objid = 0)) OR`
`33`	`33`	`(deptype = 'p' AND (dbid != 0 OR classid != 0 OR objid != 0 OR objsubid != 0));`
`34`	`34`	`dbid \| classid \| objid \| objsubid \| refclassid \| refobjid \| deptype`
`35`	`35`	`------+---------+-------+----------+------------+----------+---------`

`‎src/test/regress/sql/misc_sanity.sql`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ SELECT *`
`32`	`32`	`FROM pg_shdependas d1`
`33`	`33`	`WHERE refclassid=0OR refobjid=0OR`
`34`	`34`	`deptype NOTIN ('a','o','p','r')OR`
`35`		`- (deptype!='p'AND (dbid=0ORclassid=0OR objid=0))OR`
	`35`	`+ (deptype!='p'AND (classid=0OR objid=0))OR`
`36`	`36`	`(deptype='p'AND (dbid!=0OR classid!=0OR objid!=0OR objsubid!=0));`
`37`	`37`
`38`	`38`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit95e28b7

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/misc_sanity.out`

`‎src/test/regress/sql/misc_sanity.sql`

0 commit comments