NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit956ef58

Etsuro Fujita

committed

Clean up some misplaced comments in partition_join.sql regression test.

Also, add a comment explaining a test case.Back-patch to 11 where the regression test was added.Discussion:https://postgr.es/m/CAPmGK15adZPh2B%2BmGUjSOMH%2BH39ogDRWfCfm4G6jncZCAs9V_Q%40mail.gmail.com

1 parente5a02e0 commit956ef58Copy full SHA for 956ef58

File tree

2 files changed

+13

-8

lines changed

src/test/regress
- expected
  - partition_join.out
- sql
  - partition_join.sql

2 files changed

+13

-8

lines changed

`‎src/test/regress/expected/partition_join.out`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1996,8 +1996,8 @@ SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_m t1 LEFT JOIN prt2_m t2 ON t1.c = t2.c;`
`1996`	`1996`	`-> Seq Scan on prt2_m_p3 t2_3`
`1997`	`1997`	`(11 rows)`
`1998`	`1998`
`1999`		`--- partitionwise join can not be applied betweentables with different`
`2000`		`---partition lists`
	`1999`	`+-- partitionwise join can not be appliedfor a joinbetweenlist and range`
	`2000`	`+--partitioned tables`
`2001`	`2001`	`EXPLAIN (COSTS OFF)`
`2002`	`2002`	`SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_n t1 LEFT JOIN prt2_n t2 ON (t1.c = t2.c);`
`2003`	`2003`	`QUERY PLAN`
`@@ -2013,6 +2013,8 @@ SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_n t1 LEFT JOIN prt2_n t2 ON (t1.c = t2.c`
`2013`	`2013`	`-> Seq Scan on prt1_n_p2 t1_2`
`2014`	`2014`	`(9 rows)`
`2015`	`2015`
	`2016`	`+-- partitionwise join can not be applied between tables with different`
	`2017`	`+-- partition lists`
`2016`	`2018`	`EXPLAIN (COSTS OFF)`
`2017`	`2019`	`SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_n t1 JOIN prt2_n t2 ON (t1.c = t2.c) JOIN plt1 t3 ON (t1.c = t3.c);`
`2018`	`2020`	`QUERY PLAN`
`@@ -2035,8 +2037,8 @@ SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_n t1 JOIN prt2_n t2 ON (t1.c = t2.c) JOI`
`2035`	`2037`	`-> Seq Scan on prt1_n_p2 t1_2`
`2036`	`2038`	`(16 rows)`
`2037`	`2039`
`2038`		`--- partitionwise join can not be applied for a join betweenlist and range`
`2039`		`---partitioned tables`
	`2040`	`+-- partitionwise join can not be applied for a join betweenkey column and`
	`2041`	`+--non-key column`
`2040`	`2042`	`EXPLAIN (COSTS OFF)`
`2041`	`2043`	`SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_n t1 FULL JOIN prt1 t2 ON (t1.c = t2.c);`
`2042`	`2044`	`QUERY PLAN`

`‎src/test/regress/sql/partition_join.sql`

Lines changed: 7 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -430,15 +430,18 @@ SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_m t1 LEFT JOIN prt2_m t2 ON t1.a = t2.b;`
`430`	`430`	`EXPLAIN (COSTS OFF)`
`431`	`431`	`SELECTt1.a,t1.c,t2.b,t2.cFROM prt1_m t1LEFT JOIN prt2_m t2ONt1.c=t2.c;`
`432`	`432`
`433`		`--- partitionwise join can not be applied betweentables with different`
`434`		`---partition lists`
	`433`	`+-- partitionwise join can not be appliedfor a joinbetweenlist and range`
	`434`	`+--partitioned tables`
`435`	`435`	`EXPLAIN (COSTS OFF)`
`436`	`436`	`SELECTt1.a,t1.c,t2.b,t2.cFROM prt1_n t1LEFT JOIN prt2_n t2ON (t1.c=t2.c);`
	`437`	`+`
	`438`	`+-- partitionwise join can not be applied between tables with different`
	`439`	`+-- partition lists`
`437`	`440`	`EXPLAIN (COSTS OFF)`
`438`	`441`	`SELECTt1.a,t1.c,t2.b,t2.cFROM prt1_n t1JOIN prt2_n t2ON (t1.c=t2.c)JOIN plt1 t3ON (t1.c=t3.c);`
`439`	`442`
`440`		`--- partitionwise join can not be applied for a join betweenlist and range`
`441`		`---partitioned tables`
	`443`	`+-- partitionwise join can not be applied for a join betweenkey column and`
	`444`	`+--non-key column`
`442`	`445`	`EXPLAIN (COSTS OFF)`
`443`	`446`	`SELECTt1.a,t1.c,t2.b,t2.cFROM prt1_n t1 FULLJOIN prt1 t2ON (t1.c=t2.c);`
`444`	`447`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit956ef58

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/partition_join.out`

`‎src/test/regress/sql/partition_join.sql`

0 commit comments