Commit95219c0

committed

Avoid 0-length memcpy to NULL with EXEC_BACKEND

memcpy(NULL, src, 0) is forbidden by POSIX, even though everyproduction version of libc allows it. Let's be tidy.Per report from Thomas Munro, running UBSan with EXEC_BACKEND.Backpatch to v17, where this code was added.Discussion:https://www.postgresql.org/message-id/CA%2BhUKG%2Be-dV7YWBzfBZXsgovgRuX5VmvmOT%2Bv0aXiZJ-EKbXcw@mail.gmail.com

1 parent1906b1e commit95219c0Copy full SHA for 95219c0

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -764,7 +764,8 @@ save_backend_variables(BackendParameters param, ClientSocket client_sock,`
`764`	`764`	`strlcpy(param->pkglib_path,pkglib_path,MAXPGPATH);`
`765`	`765`
`766`	`766`	`param->startup_data_len=startup_data_len;`
`767`		`-memcpy(param->startup_data,startup_data,startup_data_len);`
	`767`	`+if (startup_data_len>0)`
	`768`	`+memcpy(param->startup_data,startup_data,startup_data_len);`
`768`	`769`
`769`	`770`	`return true;`
`770`	`771`	`}`

Comments

(0)