forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit9515299
committed
Improve handling of numeric-valued variables in pgbench.
The previous coding always stored variable values as strings, doingconversion on-the-fly when a numeric value was needed or a number was to beassigned. This was a bit inefficient and risked loss of precision forfloating-point values. The precision aspect had been hacked around byprinting doubles in "%.18e" format, which is ugly and has machine-dependentresults. Instead, arrange to preserve an assigned numeric value in theoriginal binary numeric format, converting to string only when and ifneeded. When we do need to convert a double to string, convert in "%g"format with DBL_DIG precision, which is the standard way to do it andproduces the least surprising results in most cases.The implementation supports storing both a string value and a numericvalue for any one variable, with lazy conversion between them. I alsoarranged for lazy re-sorting of the variable array when new variables areadded. That was mainly to allow a clean refactoring of putVariable()into two levels of subroutine, but it may allow us to save a few sorts.Discussion: <9188.1462475559@sss.pgh.pa.us>1 parentdaa9856 commit9515299
1 file changed
+188
-86
lines changed0 commit comments
Comments
(0)