NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit94fec48

committed

Add regression test for two-phase transaction in postgres_fdw

postgres_fdw does not support two-phase transactions, so let's add asmall negative test case to check after it. Note that this is checkedusing an end-of-xact callback to ensure a proper connection cleanup withthe foreign server, which is called before checking if a server is ableto handle 2PC with max_prepared_xacts, so this test does not need analternate output file.Author: Gilles DaroldDiscussion:https://postgr.es/m/20191108090507.GC1768@paquier.xyz

1 parent1379fd5 commit94fec48Copy full SHA for 94fec48

File tree

2 files changed

+20

-0

lines changed

contrib/postgres_fdw
- expected
  - postgres_fdw.out
- sql
  - postgres_fdw.sql

2 files changed

+20

-0

lines changed

`‎contrib/postgres_fdw/expected/postgres_fdw.out`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -8781,3 +8781,16 @@ SELECT b, avg(a), max(a), count(*) FROM pagg_tab GROUP BY b HAVING sum(a) < 700`
`8781`	`8781`
`8782`	`8782`	`-- Clean-up`
`8783`	`8783`	`RESET enable_partitionwise_aggregate;`
	`8784`	`+-- Two-phase transactions are not supported.`
	`8785`	`+BEGIN;`
	`8786`	`+SELECT count(*) FROM ft1;`
	`8787`	`+ count`
	`8788`	`+-------`
	`8789`	`+ 822`
	`8790`	`+(1 row)`
	`8791`	`+`
	`8792`	`+-- error here`
	`8793`	`+PREPARE TRANSACTION 'fdw_tpc';`
	`8794`	`+ERROR: cannot PREPARE a transaction that has operated on postgres_fdw foreign tables`
	`8795`	`+ROLLBACK;`
	`8796`	`+WARNING: there is no transaction in progress`

`‎contrib/postgres_fdw/sql/postgres_fdw.sql`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2479,3 +2479,10 @@ SELECT b, avg(a), max(a), count(*) FROM pagg_tab GROUP BY b HAVING sum(a) < 700`
`2479`	`2479`
`2480`	`2480`	`-- Clean-up`
`2481`	`2481`	`RESET enable_partitionwise_aggregate;`
	`2482`	`+`
	`2483`	`+-- Two-phase transactions are not supported.`
	`2484`	`+BEGIN;`
	`2485`	`+SELECTcount(*)FROM ft1;`
	`2486`	`+-- error here`
	`2487`	`+PREPARE TRANSACTION'fdw_tpc';`
	`2488`	`+ROLLBACK;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit94fec48

File tree

2 files changed

2 files changed

`‎contrib/postgres_fdw/expected/postgres_fdw.out`

`‎contrib/postgres_fdw/sql/postgres_fdw.sql`

0 commit comments