NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit94600dd

committed

pg_regress: Promptly detect failed postmaster startup.

Detect it the way pg_ctl's wait_for_postmaster() does. When pg_regressspawned a postmaster that failed startup, we were detecting that onlywith "pg_regress: postmaster did not respond within 60 seconds".Back-patch to 9.4 (all supported versions).Reviewed by Tom Lane.Discussion:https://postgr.es/m/20181231172922.GA199150@gust.leadboat.com

1 parentd01e75d commit94600ddCopy full SHA for 94600dd

File tree

1 file changed

-1

lines changed

src/test/regress
- pg_regress.c

1 file changed

-1

lines changed

`‎src/test/regress/pg_regress.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2414,7 +2414,7 @@ regression_main(int argc, char *argv[], init_function ifunc, test_function tfunc`
`2414`	`2414`	`* Fail immediately if postmaster has exited`
`2415`	`2415`	`*/`
`2416`	`2416`	`#ifndefWIN32`
`2417`		`-if (kill(postmaster_pid,0)!=0)`
	`2417`	`+if (waitpid(postmaster_pid,NULL,WNOHANG)==postmaster_pid)`
`2418`	`2418`	`#else`
`2419`	`2419`	`if (WaitForSingleObject(postmaster_pid,0)==WAIT_OBJECT_0)`
`2420`	`2420`	`#endif`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit94600dd

File tree

1 file changed

1 file changed

`‎src/test/regress/pg_regress.c`

0 commit comments