Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit944dc45

Browse files
committed
Fix the public schema's permissions in a separate test script.
In the wake of commitb073c3c, it's necessary to grant createpermissions on the public schema to PUBLIC to get many of thecore regression test scripts to pass. That commit did so via thequick-n-dirty expedient of adding the GRANT to the tablespace test,which runs first. This is problematic for single-machinereplication testing, though. The least painful way to run theregression tests on such a setup is to skip the tablespace test,and that no longer works.To fix, let's invent a separate "test_setup" script to run first,and put the GRANT there. Revertb073c3c's changes tothe tablespace.source files.In the future it might be good to try to reduce coupling betweenthe various test scripts by having test_setup create widely-usedobjects, with the goal that most of the scripts could run afterhaving run only test_setup. That's going to take some effort,so this commit just addresses my immediate pain point.Discussion:https://postgr.es/m/1363170.1639763559@sss.pgh.pa.us
1 parent3c6f8c0 commit944dc45

File tree

5 files changed

+12
-8
lines changed

5 files changed

+12
-8
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
-- Postgres formerly made the public schema read/write by default,
2+
-- and most of the core regression tests still expect that.
3+
GRANT ALL ON SCHEMA public TO public;

‎src/test/regress/input/tablespace.source

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ CREATE INDEX k ON testschema.tablespace_acl (c) TABLESPACE regress_tblspace;
388388
ALTER TABLE testschema.tablespace_acl OWNER TO regress_tablespace_user2;
389389

390390
SET SESSION ROLE regress_tablespace_user2;
391-
CREATETEMPTABLE tablespace_table (i int) TABLESPACE regress_tblspace; -- fail
391+
CREATE TABLE tablespace_table (i int) TABLESPACE regress_tblspace; -- fail
392392
ALTER TABLE testschema.tablespace_acl ALTER c TYPE bigint;
393393
REINDEX (TABLESPACE regress_tblspace) TABLE tablespace_table; -- fail
394394
REINDEX (TABLESPACE regress_tblspace, CONCURRENTLY) TABLE tablespace_table; -- fail
@@ -409,6 +409,3 @@ DROP SCHEMA testschema CASCADE;
409409

410410
DROP ROLE regress_tablespace_user1;
411411
DROP ROLE regress_tablespace_user2;
412-
413-
-- Rest of this suite can use the public schema freely.
414-
GRANT ALL ON SCHEMA public TO public;

‎src/test/regress/output/tablespace.source

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,7 @@ CREATE TABLE testschema.tablespace_acl (c int);
908908
CREATE INDEX k ON testschema.tablespace_acl (c) TABLESPACE regress_tblspace;
909909
ALTER TABLE testschema.tablespace_acl OWNER TO regress_tablespace_user2;
910910
SET SESSION ROLE regress_tablespace_user2;
911-
CREATETEMPTABLE tablespace_table (i int) TABLESPACE regress_tblspace; -- fail
911+
CREATE TABLE tablespace_table (i int) TABLESPACE regress_tblspace; -- fail
912912
ERROR: permission denied for tablespace regress_tblspace
913913
ALTER TABLE testschema.tablespace_acl ALTER c TYPE bigint;
914914
REINDEX (TABLESPACE regress_tblspace) TABLE tablespace_table; -- fail
@@ -934,5 +934,3 @@ drop cascades to table testschema.atable
934934
drop cascades to table testschema.tablespace_acl
935935
DROP ROLE regress_tablespace_user1;
936936
DROP ROLE regress_tablespace_user2;
937-
-- Rest of this suite can use the public schema freely.
938-
GRANT ALL ON SCHEMA public TO public;

‎src/test/regress/parallel_schedule

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@
55
# this limits the number of connections needed to run the tests.
66
# ----------
77

8-
# run tablespace by itself, and first, because it forces a checkpoint;
8+
# required setup steps
9+
test: test_setup
10+
11+
# run tablespace by itself, and early, because it forces a checkpoint;
912
# we'd prefer not to have checkpoints later in the tests because that
1013
# interferes with crash-recovery testing.
1114
test: tablespace

‎src/test/regress/sql/test_setup.sql

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
-- Postgres formerly made the public schema read/write by default,
2+
-- and most of the core regression tests still expect that.
3+
GRANT ALLON SCHEMA public TO public;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp