NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit941aa6a

committed

Check the snapshot argument of index_beginscan and family

Passing a NULL snapshot (InvalidSnapshot) is going to work but only as longas the index can't find any matching rows. This can be confusing forthe extension authors, so add an explicit check for this argument. The checkis implemented with Assert() in order to avoid overhead in release builds.Reported-by: Sven KlemmDiscussion:https://postgr.es/m/CAJ7c6TPxitD4vbKyP-mpmC1XwyHdPPqvjLzm%2BVpB88h8LGgneQ%40mail.gmail.comAuthor: Aleksander AlekseevReviewed-by: Pavel Borisov

1 parenta7885c9 commit941aa6aCopy full SHA for 941aa6a

File tree

1 file changed

-0

lines changed

src/backend/access/index
- indexam.c

1 file changed

-0

lines changed

`‎src/backend/access/index/indexam.c`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -209,6 +209,8 @@ index_beginscan(Relation heapRelation,`
`209`	`209`	`{`
`210`	`210`	`IndexScanDescscan;`
`211`	`211`
	`212`	`+Assert(snapshot!=InvalidSnapshot);`
	`213`	`+`
`212`	`214`	`scan=index_beginscan_internal(indexRelation,nkeys,norderbys,snapshot,NULL, false);`
`213`	`215`
`214`	`216`	`/*`
`@@ -237,6 +239,8 @@ index_beginscan_bitmap(Relation indexRelation,`
`237`	`239`	`{`
`238`	`240`	`IndexScanDescscan;`
`239`	`241`
	`242`	`+Assert(snapshot!=InvalidSnapshot);`
	`243`	`+`
`240`	`244`	`scan=index_beginscan_internal(indexRelation,nkeys,0,snapshot,NULL, false);`
`241`	`245`
`242`	`246`	`/*`
`@@ -403,6 +407,8 @@ index_parallelscan_estimate(Relation indexRelation, Snapshot snapshot)`
`403`	`407`	`{`
`404`	`408`	`Sizenbytes;`
`405`	`409`
	`410`	`+Assert(snapshot!=InvalidSnapshot);`
	`411`	`+`
`406`	`412`	`RELATION_CHECKS;`
`407`	`413`
`408`	`414`	`nbytes= offsetof(ParallelIndexScanDescData,ps_snapshot_data);`
`@@ -437,6 +443,8 @@ index_parallelscan_initialize(Relation heapRelation, Relation indexRelation,`
`437`	`443`	`{`
`438`	`444`	`Sizeoffset;`
`439`	`445`
	`446`	`+Assert(snapshot!=InvalidSnapshot);`
	`447`	`+`
`440`	`448`	`RELATION_CHECKS;`
`441`	`449`
`442`	`450`	`offset=add_size(offsetof(ParallelIndexScanDescData,ps_snapshot_data),`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit941aa6a

File tree

1 file changed

1 file changed

`‎src/backend/access/index/indexam.c`

0 commit comments