Commit941921b

committed

Replace occurrences of InvalidXid with InvalidTransactionId

While Xid is a known shortening of TransactionId, InvalidXid is notdefined in the code. Fix comments which mistakenly were using theshorter version.Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>Discussion:https://postgr.es/m/CALj2ACUQzdigML868nV4cojfELPkEzNLNOk7b91Pho4JB90fng@mail.gmail.com

1 parent8a42379 commit941921bCopy full SHA for 941921b

File tree

-6

lines changed

-6

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -3589,9 +3589,9 @@ heap_update(Relation relation, ItemPointer otid, HeapTuple newtup,`
`3589`	`3589`	`/*`
`3590`	`3590`	`* And also prepare an Xmax value for the new copy of the tuple. If there`
`3591`	`3591`	`* was no xmax previously, or there was one but all lockers are now gone,`
`3592`		`- * then useInvalidXid; otherwise, get the xmax from the old tuple. (In`
`3593`		`- * rare cases that might also beInvalidXid and yet not have the`
`3594`		`- * HEAP_XMAX_INVALID bit set; that's fine.)`
	`3592`	`+ * then useInvalidTransactionId; otherwise, get the xmax from the old`
	`3593`	`+ *tuple. (Inrare cases that might also beInvalidTransactionId and yet`
	`3594`	`+ *not have theHEAP_XMAX_INVALID bit set; that's fine.)`
`3595`	`3595`	`*/`
`3596`	`3596`	`if ((oldtup.t_data->t_infomask&HEAP_XMAX_INVALID)\|\|`
`3597`	`3597`	`HEAP_LOCKED_UPGRADED(oldtup.t_data->t_infomask)\|\|`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -919,9 +919,9 @@ xmin_cmp(const pairingheap_node a, const pairingheap_node b, void *arg)`
`919`	`919`	`/*`
`920`	`920`	`* SnapshotResetXmin`
`921`	`921`	`*`
`922`		`- * If there are no more snapshots, we can reset our PGPROC->xmin to InvalidXid.`
`923`		`- * Note we can do this without locking because we assume that storing an Xid`
`924`		`- * is atomic.`
	`922`	`+ * If there are no more snapshots, we can reset our PGPROC->xmin to`
	`923`	`+ *InvalidTransactionId.Note we can do this without locking because we assume`
	`924`	`+ *that storing an Xidis atomic.`
`925`	`925`	`*`
`926`	`926`	`* Even if there are some remaining snapshots, we may be able to advance our`
`927`	`927`	`* PGPROC->xmin to some degree. This typically happens when a portal is`

Comments

(0)