NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit92c7602

committed

Improve readability of some tests in strings.sql

c251336 has added some tests to check if a toast relation should beempty or not, hardcoding the toast relation name when callingpg_relation_size(). pg_class.reltoastrelid offers the same information,so simplify the tests to use that.Reviewed-by: Daniel GustafssonDiscussion:https://postgr.es/m/20190403065949.GH3298@paquier.xyz

1 parentb73c3a1 commit92c7602Copy full SHA for 92c7602

File tree

2 files changed

+12

-8

lines changed

src/test/regress
- expected
  - strings.out
- sql
  - strings.sql

2 files changed

+12

-8

lines changed

`‎src/test/regress/expected/strings.out‎`

Lines changed: 8 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1190,9 +1190,10 @@ INSERT INTO toasttest values (repeat('1234567890',300));`
`1190`	`1190`	`INSERT INTO toasttest values (repeat('1234567890',300));`
`1191`	`1191`	`INSERT INTO toasttest values (repeat('1234567890',300));`
`1192`	`1192`	`-- expect >0 blocks`
`1193`		`-select 0 = pg_relation_size('pg_toast.pg_toast_'\|\|(select oid from pg_class where relname = 'toasttest'))/current_setting('block_size')::integer as blocks;`
`1194`		`- blocks`
`1195`		`---------`
	`1193`	`+SELECT pg_relation_size(reltoastrelid) = 0 AS is_empty`
	`1194`	`+ FROM pg_class where relname = 'toasttest';`
	`1195`	`+ is_empty`
	`1196`	`+----------`
`1196`	`1197`	`f`
`1197`	`1198`	`(1 row)`
`1198`	`1199`
`@@ -1203,9 +1204,10 @@ INSERT INTO toasttest values (repeat('1234567890',300));`
`1203`	`1204`	`INSERT INTO toasttest values (repeat('1234567890',300));`
`1204`	`1205`	`INSERT INTO toasttest values (repeat('1234567890',300));`
`1205`	`1206`	`-- expect 0 blocks`
`1206`		`-select 0 = pg_relation_size('pg_toast.pg_toast_'\|\|(select oid from pg_class where relname = 'toasttest'))/current_setting('block_size')::integer as blocks;`
`1207`		`- blocks`
`1208`		`---------`
	`1207`	`+SELECT pg_relation_size(reltoastrelid) = 0 AS is_empty`
	`1208`	`+ FROM pg_class where relname = 'toasttest';`
	`1209`	`+ is_empty`
	`1210`	`+----------`
`1209`	`1211`	`t`
`1210`	`1212`	`(1 row)`
`1211`	`1213`

`‎src/test/regress/sql/strings.sql‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -375,7 +375,8 @@ INSERT INTO toasttest values (repeat('1234567890',300));`
`375`	`375`	`INSERT INTO toasttestvalues (repeat('1234567890',300));`
`376`	`376`	`INSERT INTO toasttestvalues (repeat('1234567890',300));`
`377`	`377`	`-- expect >0 blocks`
`378`		`-select0= pg_relation_size('pg_toast.pg_toast_'\|\|(selectoidfrom pg_classwhere relname='toasttest'))/current_setting('block_size')::integeras blocks;`
	`378`	`+SELECT pg_relation_size(reltoastrelid)=0AS is_empty`
	`379`	`+FROM pg_classwhere relname='toasttest';`
`379`	`380`
`380`	`381`	`TRUNCATE TABLE toasttest;`
`381`	`382`	`ALTERTABLE toasttestset (toast_tuple_target=4080);`
`@@ -384,7 +385,8 @@ INSERT INTO toasttest values (repeat('1234567890',300));`
`384`	`385`	`INSERT INTO toasttestvalues (repeat('1234567890',300));`
`385`	`386`	`INSERT INTO toasttestvalues (repeat('1234567890',300));`
`386`	`387`	`-- expect 0 blocks`
`387`		`-select0= pg_relation_size('pg_toast.pg_toast_'\|\|(selectoidfrom pg_classwhere relname='toasttest'))/current_setting('block_size')::integeras blocks;`
	`388`	`+SELECT pg_relation_size(reltoastrelid)=0AS is_empty`
	`389`	`+FROM pg_classwhere relname='toasttest';`
`388`	`390`
`389`	`391`	`DROPTABLE toasttest;`
`390`	`392`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit92c7602

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/strings.out‎`

`‎src/test/regress/sql/strings.sql‎`

0 commit comments