Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit92c651f

Browse files
committed
Fix an oversight in mergejoin planning: the planner would reject a
mergejoin possibility where the inner rel was less well sorted thanthe outer (ie, it matches some but not all of the merge clauses thatcan work with the outer), if the inner path in question is also theoverall cheapest path for its rel. This is an old bug, but I'm notsure it's worth back-patching, because it's such a corner case.Noted while investigating a test case from Peter Hardman.
1 parent144b0ae commit92c651f

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

‎src/backend/optimizer/path/joinpath.c

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/optimizer/path/joinpath.c,v 1.105 2006/07/14 14:52:20 momjian Exp $
11+
* $PostgreSQL: pgsql/src/backend/optimizer/path/joinpath.c,v 1.106 2006/08/17 17:06:37 tgl Exp $
1212
*
1313
*-------------------------------------------------------------------------
1414
*/
@@ -542,8 +542,11 @@ match_unsorted_outer(PlannerInfo *root,
542542
* Look for presorted inner paths that satisfy the innersortkey list
543543
* --- or any truncation thereof, if we are allowed to build a
544544
* mergejoin using a subset of the merge clauses. Here, we consider
545-
* both cheap startup cost and cheap total cost. Ignore
546-
* inner_cheapest_total, since we already made a path with it.
545+
* both cheap startup cost and cheap total cost. We can ignore
546+
* inner_cheapest_total on the first iteration, since we already made
547+
* a path with it --- but not on later iterations with shorter
548+
* sort keys, because then we are considering a different situation,
549+
* viz using a simpler mergejoin to avoid a sort of the inner rel.
547550
*/
548551
num_sortkeys=list_length(innersortkeys);
549552
if (num_sortkeys>1&& !useallclauses)
@@ -568,7 +571,8 @@ match_unsorted_outer(PlannerInfo *root,
568571
trialsortkeys,
569572
TOTAL_COST);
570573
if (innerpath!=NULL&&
571-
innerpath!=inner_cheapest_total&&
574+
(innerpath!=inner_cheapest_total||
575+
sortkeycnt<num_sortkeys)&&
572576
(cheapest_total_inner==NULL||
573577
compare_path_costs(innerpath,cheapest_total_inner,
574578
TOTAL_COST)<0))
@@ -603,7 +607,8 @@ match_unsorted_outer(PlannerInfo *root,
603607
trialsortkeys,
604608
STARTUP_COST);
605609
if (innerpath!=NULL&&
606-
innerpath!=inner_cheapest_total&&
610+
(innerpath!=inner_cheapest_total||
611+
sortkeycnt<num_sortkeys)&&
607612
(cheapest_startup_inner==NULL||
608613
compare_path_costs(innerpath,cheapest_startup_inner,
609614
STARTUP_COST)<0))

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp