NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit926bbab

committed

Make /contrib install/uninstall script consistent:

remove transactionsuse create or replace functionmake formatting consistentset search patch on first lineAdd documentation on modifying *.sql to set the search patch, andmention that major upgrades should still run the installation scripts.Some of these issues were spotted by Tom today.

1 parent541ff40 commit926bbabCopy full SHA for 926bbab

File tree

54 files changed

+1068

-1037

lines changed

contrib
- adminpack
  - adminpack.sql.in
  - uninstall_adminpack.sql
- btree_gist
  - btree_gist.sql.in
  - uninstall_btree_gist.sql
- chkpass
  - chkpass.sql.in
  - uninstall_chkpass.sql
- cube
  - cube.sql.in
  - uninstall_cube.sql
- dblink
  - dblink.sql.in
  - uninstall_dblink.sql
- dict_int
  - dict_int.sql.in
  - uninstall_dict_int.sql
- dict_xsyn
  - dict_xsyn.sql.in
  - uninstall_dict_xsyn.sql
- earthdistance
  - uninstall_earthdistance.sql
- fuzzystrmatch
  - fuzzystrmatch.sql.in
  - uninstall_fuzzystrmatch.sql
- hstore
  - hstore.sql.in
  - uninstall_hstore.sql
- intagg
  - uninstall_int_aggregate.sql
- intarray
  - _int.sql.in
  - uninstall__int.sql
- isn
  - isn.sql.in
  - uninstall_isn.sql
- lo
  - lo.sql.in
  - lo_test.sql
  - uninstall_lo.sql
- ltree
  - ltree.sql.in
  - ltreetest.sql
  - uninstall_ltree.sql
- pageinspect
  - uninstall_pageinspect.sql
- pg_buffercache
  - pg_buffercache.sql.in
  - uninstall_pg_buffercache.sql
- pg_freespacemap
  - pg_freespacemap.sql.in
  - uninstall_pg_freespacemap.sql
- pg_trgm
  - pg_trgm.sql.in
  - uninstall_pg_trgm.sql
- pgcrypto
  - uninstall_pgcrypto.sql
- pgrowlocks
  - uninstall_pgrowlocks.sql
- pgstattuple
  - uninstall_pgstattuple.sql
- seg
  - seg.sql.in
  - uninstall_seg.sql
- sslinfo
  - sslinfo.sql.in
  - uninstall_sslinfo.sql
- tablefunc
  - uninstall_tablefunc.sql
- test_parser
  - test_parser.sql.in
  - uninstall_test_parser.sql
- tsearch2
  - tsearch.sql.in
  - untsearch.sql.in
- uuid-ossp
  - uninstall_uuid-ossp.sql
  - uuid-ossp.sql.in
- xml2
  - pgxml.sql.in
  - uninstall_pgxml.sql
doc/src/sgml
- contrib.sgml

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+1068

-1037

lines changed

`‎contrib/adminpack/adminpack.sql.in`

Lines changed: 36 additions & 25 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,41 +1,52 @@`
	`1`	`+-- Adjust this setting to control where the objects get created.`
	`2`	`+SET search_path = public;`
	`3`	`+`
`1`	`4`	`/* ***********************************************`
`2`		`- * Administrative functions for PostgreSQL`
	`5`	`+ * Administrative functions for PostgreSQL`
`3`	`6`	`* *********************************************** */`
`4`	`7`
`5`	`8`	`/* generic file access functions */`
`6`	`9`
`7`		`-CREATE FUNCTION pg_catalog.pg_file_write(text, text, bool) RETURNS bigint`
`8`		`- AS 'MODULE_PATHNAME', 'pg_file_write'`
`9`		`-LANGUAGE C VOLATILE STRICT;`
	`10`	`+CREATE OR REPLACE FUNCTION pg_catalog.pg_file_write(text, text, bool)`
	`11`	`+RETURNS bigint`
	`12`	`+AS 'MODULE_PATHNAME', 'pg_file_write'`
	`13`	`+LANGUAGE C VOLATILE STRICT;`
`10`	`14`
`11`		`-CREATE FUNCTION pg_catalog.pg_file_rename(text, text, text) RETURNS bool`
`12`		`- AS 'MODULE_PATHNAME', 'pg_file_rename'`
`13`		`-LANGUAGE C VOLATILE;`
	`15`	`+CREATE OR REPLACE FUNCTION pg_catalog.pg_file_rename(text, text, text)`
	`16`	`+RETURNS bool`
	`17`	`+AS 'MODULE_PATHNAME', 'pg_file_rename'`
	`18`	`+LANGUAGE C VOLATILE;`
`14`	`19`
`15`		`-CREATE FUNCTION pg_catalog.pg_file_rename(text, text) RETURNS bool`
`16`		`- AS 'SELECT pg_file_rename($1, $2, NULL); '`
`17`		`-LANGUAGE SQL VOLATILE STRICT;`
	`20`	`+CREATE OR REPLACE FUNCTION pg_catalog.pg_file_rename(text, text)`
	`21`	`+RETURNS bool`
	`22`	`+AS 'SELECT pg_file_rename($1, $2, NULL); '`
	`23`	`+LANGUAGE SQL VOLATILE STRICT;`
`18`	`24`
`19`		`-CREATE FUNCTION pg_catalog.pg_file_unlink(text) RETURNS bool`
`20`		`- AS 'MODULE_PATHNAME', 'pg_file_unlink'`
`21`		`-LANGUAGE C VOLATILE STRICT;`
	`25`	`+CREATE OR REPLACE FUNCTION pg_catalog.pg_file_unlink(text)`
	`26`	`+RETURNS bool`
	`27`	`+AS 'MODULE_PATHNAME', 'pg_file_unlink'`
	`28`	`+LANGUAGE C VOLATILE STRICT;`
`22`	`29`
`23`		`-CREATE FUNCTION pg_catalog.pg_logdir_ls() RETURNS setof record`
`24`		`- AS 'MODULE_PATHNAME', 'pg_logdir_ls'`
`25`		`-LANGUAGE C VOLATILE STRICT;`
	`30`	`+CREATE OR REPLACE FUNCTION pg_catalog.pg_logdir_ls()`
	`31`	`+RETURNS setof record`
	`32`	`+AS 'MODULE_PATHNAME', 'pg_logdir_ls'`
	`33`	`+LANGUAGE C VOLATILE STRICT;`
`26`	`34`
`27`	`35`
`28`	`36`	`/* Renaming of existing backend functions for pgAdmin compatibility */`
`29`	`37`
`30`		`-CREATE FUNCTION pg_catalog.pg_file_read(text, bigint, bigint) RETURNS text`
`31`		`- AS 'pg_read_file'`
`32`		`-LANGUAGE INTERNAL VOLATILE STRICT;`
	`38`	`+CREATE OR REPLACE FUNCTION pg_catalog.pg_file_read(text, bigint, bigint)`
	`39`	`+RETURNS text`
	`40`	`+AS 'pg_read_file'`
	`41`	`+LANGUAGE INTERNAL VOLATILE STRICT;`
`33`	`42`
`34`		`-CREATE FUNCTION pg_catalog.pg_file_length(text) RETURNS bigint`
`35`		`- AS 'SELECT size FROM pg_stat_file($1)'`
`36`		`- LANGUAGE SQL VOLATILE STRICT;`
	`43`	`+CREATE OR REPLACE FUNCTION pg_catalog.pg_file_length(text)`
	`44`	`+RETURNS bigint`
	`45`	`+AS 'SELECT size FROM pg_stat_file($1)'`
	`46`	`+LANGUAGE SQL VOLATILE STRICT;`
`37`	`47`
`38`		`-CREATE FUNCTION pg_catalog.pg_logfile_rotate() RETURNS int4`
`39`		`- AS 'pg_rotate_logfile'`
`40`		`- LANGUAGE INTERNAL VOLATILE STRICT;`
	`48`	`+CREATE OR REPLACE FUNCTION pg_catalog.pg_logfile_rotate()`
	`49`	`+RETURNS int4`
	`50`	`+AS 'pg_rotate_logfile'`
	`51`	`+LANGUAGE INTERNAL VOLATILE STRICT;`
`41`	`52`

`‎contrib/adminpack/uninstall_adminpack.sql`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,6 @@`
	`1`	`+-- Adjust this setting to control where the objects get dropped.`
	`2`	`+SET search_path= public;`
	`3`	`+`
`1`	`4`	`DROPFUNCTIONpg_catalog.pg_file_write(text,text, bool) ;`
`2`	`5`	`DROPFUNCTIONpg_catalog.pg_file_rename(text,text,text) ;`
`3`	`6`	`DROPFUNCTIONpg_catalog.pg_file_rename(text,text) ;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit926bbab

File tree

54 files changed

Some content is hidden

54 files changed

`‎contrib/adminpack/adminpack.sql.in`

`‎contrib/adminpack/uninstall_adminpack.sql`

0 commit comments