NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9255d21

committed

Move postmaster's RemovePgTempFiles call to a less randomly chosen place.

There is no reason to do this as early as possible in postmaster startup,and good reason not to do it until we have completely created thepostmaster's lock file, namely that it might contribute to pg_ctl thinkingthat postmaster startup has timed out. (This would require a ratherunusual amount of time to be spent scanning temp file directories, but wehave at least one field report of it happening reproducibly.)Back-patch to 9.1. Before that, pg_ctl didn't wait for additional info tobe added to the lock file, so it wasn't a problem.Note that this is not a complete fix to the slow-start issue in 9.1,because we still had identify_system_timezone being run during postmasterstart in 9.1. But that's at least a reasonably well-defined delay, withan easy workaround if needed, whereas the temp-files scan is not sopredictable and cannot be avoided.

1 parent435a143 commit9255d21Copy full SHA for 9255d21

File tree

1 file changed

-6

lines changed

src/backend/postmaster
- postmaster.c

1 file changed

-6

lines changed

`‎src/backend/postmaster/postmaster.c`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -826,12 +826,6 @@ PostmasterMain(int argc, char *argv[])`
`826`	`826`	`*/`
`827`	`827`	`process_shared_preload_libraries();`
`828`	`828`
`829`		`-/*`
`830`		`- * Remove old temporary files.At this point there can be no other`
`831`		`- * Postgres processes running in this directory, so this should be safe.`
`832`		`- */`
`833`		`-RemovePgTempFiles();`
`834`		`-`
`835`	`829`	`/*`
`836`	`830`	`* Establish input sockets.`
`837`	`831`	`*/`
`@@ -1104,6 +1098,12 @@ PostmasterMain(int argc, char *argv[])`
`1104`	`1098`	`}`
`1105`	`1099`	`load_ident();`
`1106`	`1100`
	`1101`	`+/*`
	`1102`	`+ * Remove old temporary files.At this point there can be no other`
	`1103`	`+ * Postgres processes running in this directory, so this should be safe.`
	`1104`	`+ */`
	`1105`	`+RemovePgTempFiles();`
	`1106`	`+`
`1107`	`1107`	`/*`
`1108`	`1108`	`* Remember postmaster startup time`
`1109`	`1109`	`*/`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9255d21

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/postmaster.c`

0 commit comments