forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit924e039
committed
Read extension script files in text not binary mode.
This change affects only Windows, where it should cause DOS-stylenewlines (\r\n) to be converted to plain \n during script loading.This eliminates one potential discrepancy in the behavior ofextension script files between Windows and non-Windows. Whilethere's a small chance that this might cause undesirable behaviorchanges for some extensions, it can also be argued that this mayremove behavioral surprises for others. An example is that inthe buildfarm, we are getting different results for the testsadded by commit774171c depending on whether our git tree hasbeen checked out with Unix or DOS newlines.The choice to use binary mode goes all the way back to our inventionof extensions in commitd9572c4. However, I suspect it was notthought through carefully but was just a side-effect of the readyavailability of an almost-suitable function read_binary_file().On balance, changing to text mode seems like a better answer thanother ways in which we might fix the inconsistent test results.Discussion:https://postgr.es/m/2480333.1729784872@sss.pgh.pa.us1 parentde380a6 commit924e039
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3639 | 3639 | | |
3640 | 3640 | | |
3641 | 3641 | | |
3642 | | - | |
| 3642 | + | |
3643 | 3643 | | |
3644 | 3644 | | |
3645 | 3645 | | |
| |||
0 commit comments
Comments
(0)