NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit92273d4

committed

Fix potential rare failure in the kerberos TAP tests

Instead of writing a query to psql's stdin, which can cause a failurewhere psql exits before writing, reporting a write failure with a brokenpipe, this changes the logic to use -c. This was not seen in thebuildfarm as no animals with a sensitive environment are running thekerberos tests, but let's be safe.HEAD is able to handle the situation as of6d41dd0 for all the testsuites doing connection checks. f44b9b6 has fixed the same problem forthe LDAP tests.Discussion:https://postgr.es/m/YGu7ceWAiSNQDgH5@paquier.xyzBackpatch-through: 11

1 parentdd5b7e4 commit92273d4Copy full SHA for 92273d4

File tree

1 file changed

-2

lines changed

src/test/kerberos/t
- 001_auth.pl

1 file changed

-2

lines changed

`‎src/test/kerberos/t/001_auth.pl`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -177,13 +177,15 @@ sub test_access`
`177`	`177`	`# need to connect over TCP/IP for Kerberos`
`178`	`178`	`my ($res,$stdoutres,$stderrres) =$node->psql(`
`179`	`179`	`'postgres',`
`180`		`-"$query",`
	`180`	`+undef,`
`181`	`181`	`extra_params=> [`
`182`	`182`	`'-XAtd',`
`183`	`183`	`$node->connstr('postgres')`
`184`	`184`	`." host=$host hostaddr=$hostaddr$gssencmode",`
`185`	`185`	`'-U',`
`186`		`-$role`
	`186`	`+$role,`
	`187`	`+'-c',`
	`188`	`+$query`
`187`	`189`	`]);`
`188`	`190`
`189`	`191`	`# If we get a query result back, it should be true.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit92273d4

File tree

1 file changed

1 file changed

`‎src/test/kerberos/t/001_auth.pl`

0 commit comments