Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit92155e1

Browse files
committed
Fix incorrect TAP test ordering
Using a test function before a possible skip_all is incorrect. If theskip_all is called, the test output will become incorrect and the testfile will fail.a4f23f9 introduced a new test before skip_all. After discussion,this doesn't really need to be a test. Instead, we just bail out ifthe condition is not satisfied.Discussion:https://www.postgresql.org/message-id/af5567a1-aea6-fbdb-7e4b-d1e23a43c43b@enterprisedb.com
1 parent1d70fb4 commit92155e1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎src/bin/pg_amcheck/t/004_verify_heapam.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ sub write_tuple
340340
FROM heap_page_items(get_raw_page('test', 'main', 0))
341341
)
342342
);
343-
is(scalar@lp_off,$ROWCOUNT,"acquiredrowoffsets");
343+
scalar@lp_off ==$ROWCOUNTor BAIL_OUT("rowoffset counts mismatch");
344344

345345
# Sanity check that our 'test' table on disk layout matches expectations. If
346346
# this is not so, we will have to skip the test until somebody updates the test

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp